Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark can't move to a subfolder #11893

Closed
jamesray1 opened this issue Nov 10, 2017 · 4 comments
Closed

Bookmark can't move to a subfolder #11893

jamesray1 opened this issue Nov 10, 2017 · 4 comments
Assignees
@NejcZdovc
Labels
feature/bookmarks misc/drag-and-drop priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@jamesray1
Copy link

jamesray1 commented Nov 10, 2017 •
edited by srirambv
Loading

Test plan

  1. Add a couple of bookmark to toolbar
  2. Add a bookmark folder
  3. Ensure you are able to drag and drop a bookmark into bookmark folder
  4. Add a bookmark sub-folder to the folder in step 2
  5. Ensure you are able to drag and drop a bookmark into the bookmark sub-folder

Description

Create a folder in the bookmarks bar, then add a sub-folder to that folder. Then add a bookmark to the bookmarks bar, and click and drag it to the empty sub-folder. It doesn't work.

If you add a sub-folder to that sub-folder, you are then able to click and drag the bookmark. This bug appears to be related to #10157, not being able to click and drag a bookmark to the other bookmarks folder in the bookmark manager. Generally, you can't click and drag a bookmark to an empty bookmark folder. You have to add something to the empty folder via starring a page to said empty folder, or by adding a folder to the empty folder. There is no issue dragging bookmarks or folders to a non-empty folder.

Reproduces how often:

100%

Brave Version

about:brave info:

Brave: 0.19.80
rev: 7d07299
Muon: 4.5.13
libchromiumcontent: 62.0.3202.75
V8: 6.2.414.36
Node.js: 7.9.0
Update Channel: Release
OS Platform: Linux
OS Release: 4.13.0-17-generic
OS Architecture: x64

Reproducible on current live release:
Yes.
@julien-l julien-l mentioned this issue Nov 17, 2017
Closed
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added the priority/P3 Major loss of function. label Nov 30, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) Nov 30, 2017
@NejcZdovc
Copy link
Contributor

can't reproduce this on 0.20 so appears to be fixed

@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.20.x (Beta Channel) Jan 5, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 5, 2018
@jamesray1 jamesray1 mentioned this issue Jan 6, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@kjozwiak
Copy link
Member

@jamesray1 if you have the time, could you download the latest 0.20.x BETA [1] and see if you can reproduce this anymore?

[1] https://github.com/brave/browser-laptop/releases/

@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
@jamesray1
Copy link
Author

Works now!

Brave: 0.20.42
V8: 6.4.388.41
rev: 096c7cb
Muon: 4.8.2
OS Release: 4.13.0-36-generic
Update Channel: Release
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.140

@kjozwiak
Copy link
Member

Awesome, thanks for checking @jamesray1!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks misc/drag-and-drop priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@kjozwiak @luixxiul @bsclifton @NejcZdovc @jamesray1 @srirambv @LaurenWags