You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
If a user wants to use the setting 'restore my tabs from last state' but also have multiple home pages for fresh windows, it does not work. It only works if you want to have your homepages show for restored and new windows
Steps to Reproduce
Preferences, set 'Brave starts with My windows / tabs from last time'
Preferences, set 'A new tab shows My home page'
Preferences, set 'My homepage is: https://brave.com|https://github.com
Open new window, CTRLorCMD+N
Actual result:
5. Only one frame is shown
Expected result:
6. Multiple frames should be shown
Reproduces how often:
100%
Brave Version
about:brave info:
0.22 master
Reproducible on current live release:
yes
The text was updated successfully, but these errors were encountered:
Can be fixed by removing the requirement of getFramesForNewWindow in windowsReducer.js (from #11764) that the frames are provided only if 'Brave starts with my homepage' is set - this logic is for any new windows, not just the startup window, and this preference should set whether the restored state is provided to the NEW_WINDOW action, not this function.
Description
If a user wants to use the setting 'restore my tabs from last state' but also have multiple home pages for fresh windows, it does not work. It only works if you want to have your homepages show for restored and new windows
Steps to Reproduce
https://brave.com|https://github.com
Actual result:
5. Only one frame is shown
Expected result:
6. Multiple frames should be shown
Reproduces how often:
100%
Brave Version
about:brave info:
0.22 master
Reproducible on current live release:
yes
The text was updated successfully, but these errors were encountered: