Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Multiple home pages not working for additional new windows #12057

Open
petemill opened this issue Nov 22, 2017 · 1 comment
Open

Multiple home pages not working for additional new windows #12057

petemill opened this issue Nov 22, 2017 · 1 comment
Assignees

Comments

@petemill
Copy link
Member

Description

If a user wants to use the setting 'restore my tabs from last state' but also have multiple home pages for fresh windows, it does not work. It only works if you want to have your homepages show for restored and new windows

Steps to Reproduce

  1. Preferences, set 'Brave starts with My windows / tabs from last time'
  2. Preferences, set 'A new tab shows My home page'
  3. Preferences, set 'My homepage is: https://brave.com|https://github.com
  4. Open new window, CTRLorCMD+N

Actual result:
5. Only one frame is shown

Expected result:
6. Multiple frames should be shown

Reproduces how often:
100%

Brave Version

about:brave info:
0.22 master

Reproducible on current live release:
yes

@petemill
Copy link
Member Author

Can be fixed by removing the requirement of getFramesForNewWindow in windowsReducer.js (from #11764) that the frames are provided only if 'Brave starts with my homepage' is set - this logic is for any new windows, not just the startup window, and this preference should set whether the restored state is provided to the NEW_WINDOW action, not this function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant