Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only TOS text should be clickable #12137

Closed
srirambv opened this issue Nov 29, 2017 · 1 comment
Closed

Only TOS text should be clickable #12137

srirambv opened this issue Nov 29, 2017 · 1 comment
Labels
0.19.x issue first seen in 0.19.x feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 29, 2017 •
edited by luixxiul
Loading

Test plan

#12140

Description

Only TOS text should be clickable

Steps to Reproduce

  1. Clean install 0.19.99
  2. Open payments
  3. Hover over TOS div, click anywhere on the div, opens TOS tab

Actual result:
bat-tos

Expected result:
Only the TOS text should be clickable

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.99
rev 43f7a01
Muon 4.5.16
libchromiumcontent 62.0.3202.94
V8 6.2.414.42
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.15063
OS Architecture x64

Reproducible on current live release:
Yes

Additional Information

cc: @cezaraugusto @NejcZdovc
@srirambv srirambv added 0.19.x issue first seen in 0.19.x feature/rewards polish Nice to have — usually related to front-end/visual tasks. labels Nov 29, 2017
@srirambv srirambv added this to the Triage Backlog milestone Nov 29, 2017
@luixxiul luixxiul mentioned this issue Nov 30, 2017
Merged
8 tasks
@luixxiul luixxiul self-assigned this Dec 2, 2017
@luixxiul luixxiul modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Dec 5, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@LaurenWags LaurenWags mentioned this issue May 8, 2018
Closed
This was referenced Jun 11, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018 •
edited by kjozwiak
Loading

Verified on Windows 10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 19, 2018
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
0.19.x issue first seen in 0.19.x feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @kjozwiak @luixxiul @srirambv @btlechowski @GeetaSarvadnya