Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restart notification should be global notification bar #12216

Closed
srirambv opened this issue Dec 7, 2017 · 0 comments
Closed

Restart notification should be global notification bar #12216

srirambv opened this issue Dec 7, 2017 · 0 comments
Assignees
@diracdeltas
Labels
bug feature/notificationbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 7, 2017 •
edited by luixxiul
Loading

Test plan

#12330 (comment)

Description

Restart notification should be global notification bar

Steps to Reproduce

  1. Clean install 0.19.108
  2. Clear browsing data, notification bar is global shown on all tabs but is shown as a tab specific notification
  3. Change browser setting to trigger restart, notification is shown as tab specific notification but visible on all tabs

Actual result:
image

Expected result:
All restart notification should be global

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.108
rev d1b0922
Muon 4.5.22
libchromiumcontent 63.0.3239.70
V8 6.3.292.44
Node.js 7.9.0
Update Channel nightly
OS Platform Microsoft Windows
OS Release 10.0.16299
OS Architecture x64

Reproducible on current live release:
Yes

Additional Information

cc: @diracdeltas
@srirambv srirambv added this to the Triage Backlog milestone Dec 7, 2017
@diracdeltas diracdeltas self-assigned this Dec 19, 2017
diracdeltas added a commit that referenced this issue Dec 19, 2017
@diracdeltas
Add property for global non-ledger notificationBar
6a3142d 
Fix #12216

Test Plan:
1. check that there are no new notificationBar test failures in travis
2. go to about:preferences
3. change PDF.JS setting. the 'Restart now?' notification should appear above the tabs bar.
@diracdeltas diracdeltas modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Dec 19, 2017
@diracdeltas diracdeltas mentioned this issue Dec 19, 2017
Merged
8 tasks
This was referenced Dec 27, 2017
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/notificationbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@diracdeltas @luixxiul @srirambv @LaurenWags