Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarks Toolbar Dialog is closing incorrectly (maybe check some other dialogs too...) #12498

Closed
NejcZdovc opened this issue Jan 4, 2018 · 5 comments · Fixed by #14162
Closed

Bookmarks Toolbar Dialog is closing incorrectly (maybe check some other dialogs too...) #12498

NejcZdovc opened this issue Jan 4, 2018 · 5 comments · Fixed by #14162
Assignees
@bsclifton
Labels
0.23.x issue first seen in 0.23.x priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Description

When you click inside dialog, dialog is closed

Steps to Reproduce

  1. Right click on bookmark toolbar
  2. Click Add Folder
  3. Click on dialog title

Actual result:

Dialog is closed

Expected result:
Dialog should be only closed when you click outside the dialog.

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information
@NejcZdovc NejcZdovc added 0.22.x issue first seen in 0.22.x regression labels Jan 4, 2018
@NejcZdovc NejcZdovc added this to the 0.22.x (Nightly Channel) milestone Jan 4, 2018
@NejcZdovc
Copy link
Contributor Author

@luixxiul I noticed that dialog is changed in 0.22. Any idea what could be a reason for this regression?

@NejcZdovc NejcZdovc added release/blocking priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. labels Jan 10, 2018
@luixxiul
Copy link
Contributor

@NejcZdovc Sorry, I'm not sure anymore.

@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@alexwykoff
Copy link
Contributor

@NejcZdovc please look at this and if fixed please close.

@alexwykoff alexwykoff added 0.23.x issue first seen in 0.23.x and removed 0.22.x issue first seen in 0.22.x labels Mar 13, 2018
@bsclifton bsclifton changed the title Dialog is closing incorectly Dialog is closing incorrectly Mar 13, 2018
@NejcZdovc
Copy link
Contributor Author

still a problem

@alexwykoff alexwykoff changed the title Dialog is closing incorrectly Bookmarks Toolbar Dialog is closing incorrectly (maybe check some other dialogs too...) May 8, 2018
@bsclifton bsclifton mentioned this issue May 17, 2018
Merged
10 tasks
This was referenced Jun 11, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
0.23.x issue first seen in 0.23.x priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Revert Aphrodite changes that were breaking bookmark modals
8 participants
@bbondy @alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski