Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Twitch: Log time when closing a video #13259

Closed
NejcZdovc opened this issue Feb 22, 2018 · 4 comments
Closed

Twitch: Log time when closing a video #13259

NejcZdovc opened this issue Feb 22, 2018 · 4 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 22, 2018 •
edited by LaurenWags
Loading

Test Plan

#13326

Description

We want to log remaining time (not logged yet) when you switch to another video or when video ends.
@NejcZdovc NejcZdovc self-assigned this Feb 22, 2018
@NejcZdovc NejcZdovc added this to the Triage Backlog milestone Feb 22, 2018
@arsalankhalid
Copy link
Contributor

I really like this task, would love to take a stab after we sync up in a discussion, and close out that other minor rewards typography issue.

Arsalan

@NejcZdovc
Copy link
Contributor Author

@arsalankhalid Sure we can talk about this one

@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.22.x (Developer Channel) Mar 15, 2018
@NejcZdovc
Copy link
Contributor Author

Problem with this issue is that twitch is not handling video end correctly. We added support for video end event in #13326 so we should be good when twitch fixes it.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 23, 2018 •
edited
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Win7 x64:

  • 0.22.8: 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Ubuntu 16.04 using

  • 0.22.9 e0fc152
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

This was referenced Mar 28, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @arsalankhalid @NejcZdovc @LaurenWags @btlechowski