Notify user why contribution is pushed back (30 minute min browsing time)

[NejcZdovc]

Test Plan

1. Enable payments and fund wallet
2. Visit any site for min time so that its added to the ledger table, ensure the total time spent is less than 30 mins
3. Close browser and change reconcile timestamp to more than 3 days from current date
4. Launch browser using LEDGER_NO_DELAY=true LEDGER_VERBOSE=true <browser_path>
5. Notification shown reconcile date is pushed back as min 30 mins browsing time is not met

Description

We want to display some notification on payments page, when contribution is due, but min browse time is not meet.

Steps to Reproduce

1. Enable payments
2. Visit one site for few minutes
3. Change reconcile stamp so that you trigger contribution

Actual result:

User contribution date was pushed back

Expected result:
We should notify user why contribution was pushed back for 3 days.

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

[realuser]

Is it 30 minutes per site? Or 30 minutes total?

1. If I visit one site for 31 minutes and another site for 4 minutes total, will they both receive a contribution or only site visited greater than 30 minutes?

2. If I visit one site for 16 minutes and another for 16 minutes total, will either receive a contribution?

Is this documented somewhere?

[NejcZdovc]

@realuser this is 30 minutes total. So you need to have at least 30min recorder time in you payments table

[srirambv]

Issue doesn't seem fixed. STR followed

1. Enable Payments
2. Fund wallet
3. Visit sites to add to ledger table
4. Change reconcile to older than 5 days
5. Launch browser with LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true to trigger reconcile
6. Reconcile succeeds and no notification shown on UI that reconcile has been pushed back by 3 days

Issue reproduced by @kjozwiak by setting reconcile back to 15 days and still payment went through

[NejcZdovc]

@srirambv you shouldn't use LEDGER_NO_FUZZING when testing this one, because you disabled this pushback. Please try without it.

[kjozwiak]

@NejcZdovc when @srirambv and me went through the above, we usedLEDGER_NO_FUZZING. I'm guessing that's why the contribution went through? Fuzzing controls the push back if the 30min requirement isn't met correct? Should we run through the above case using only LEDGER_NO_DELAY=true and not LEDGER_NO_FUZZING=true?

Edited:

Probably should have refreshed the page first before replying as @NejcZdovc already replied and answered.

[srirambv]

Verified on Windows x64

• 0.22.707 5f2fcda
• libchromiumcontent 66.0.3359.139
• muon: 6.0.9

Verified by both @kjozwiak & @LaurenWags on macOS 10.13.3 x64 using the following builds:

• 0.22.707 5f2fcda
• libchromiumcontent: 66.0.3359.139
• Muon: 6.0.9

Verified with Mint 18.3 x64 using the following build:

• 0.22.711 31d6bcc
• Muon: 6.0.9
• libchromiumcontent: 66.0.3359.139