This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Creating new tab moves to first tab page and back again #14101
Assignees
Labels
0.22.x-single-webview
Issue first seen on single-webview build against v0.22.x branch
feature/tab-page
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
regression
release-notes/exclude
Milestone
Comments
petemill
added
regression
feature/tab-page
0.22.x-single-webview
petemill
added a commit
that referenced
this issue
May 11, 2018
…he frame list Fix #14101 Whilst we do not display a tab until it has received tab-inserted-at and therefore has an index, we do switch the active Tab Page to the index of the new tab (if it is active), which would be the index of the tab page at tab index 0. A better fix would be to not add the frame to the window state until tab-inserted-at has been received. This could also help performance, especially if batched.
10 tasks
petemill
added a commit
that referenced
this issue
May 11, 2018
…he frame list Fix #14101 Whilst we do not display a tab until it has received tab-inserted-at and therefore has an index, we do switch the active Tab Page to the index of the new tab (if it is active), which would be the index of the tab page at tab index 0. A better fix would be to not add the frame to the window state until tab-inserted-at has been received. This could also help performance, especially if batched.
petemill
added a commit
that referenced
this issue
May 12, 2018
…he frame list Fix #14101 Whilst we do not display a tab until it has received tab-inserted-at and therefore has an index, we do switch the active Tab Page to the index of the new tab (if it is active), which would be the index of the tab page at tab index 0. A better fix would be to not add the frame to the window state until tab-inserted-at has been received. This could also help performance, especially if batched.
This was referenced May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reported by @alexwykoff
Description
When a new tab is added, the tab page briefly switches to the first one, and then back again the last one. This is because the tab is first created without an index, and put at the beginning, and then moved by muon to the last tab index.
Test plan / Steps to Reproduce
Actual result:
Tab is opened in the correct tab page but tab page switches to the first tab page and then quickly back again.
Expected result:
Tab page does not change
Reproduces how often:
100%
Brave Version
about:brave info:
0.22.709
Reproducible on current live release:
No
Additional Information
The text was updated successfully, but these errors were encountered: