Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable "Always ask me where to save files" still ask user and open Save As dialogue #14625

Closed
eljuno opened this issue Jul 1, 2018 · 10 comments
Closed

Disable "Always ask me where to save files" still ask user and open Save As dialogue #14625

eljuno opened this issue Jul 1, 2018 · 10 comments
Assignees
@jumde
Labels
0.23.x issue first seen in 0.23.x bug feature/download needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/not-blocking release-notes/include
Milestone
0.23.x Release 4 ...

Comments

@eljuno
Copy link
Contributor

eljuno commented Jul 1, 2018 •
edited by bsclifton
Loading

Test plan

See brave/muon#630

Description

Reported via Twitter https://twitter.com/djSTICKYBUDS/status/1013481022174818304

Disabling "Always ask me where to save files" still open Save As dialogue. When this setting disabled, it should download the files without opening Save As dialogue. Stopped working with latest release 0.23.19.

Steps to Reproduce

  1. Disable "Always ask me where to save files" at Preferences > General
  2. Open any site, try to save or download files
  3. Brave open Save As dialogue

Actual result:

Brave open Save As dialogue

Expected result:
Brave should download the files without opening Save As dialogue. File should be downloaded to download path that set by user or to Downloads folder.

Reproduces how often:

100%

Brave Version

about:brave info:

Brave: 0.23.19
V8: 6.7.288.46
rev: 178c3fb
Muon: 7.1.3
OS Release: 6.3.9600
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Tor: 0.3.3.7 (git-035a35178c92da94)
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.87

Reproducible on current live release:

Yes

Additional Information

cc @LaurenWags @srirambv
@srirambv
Copy link
Collaborator

srirambv commented Jul 2, 2018

+1 from https://community.brave.com/t/bad-bug-concerning-the-location-of-where-files-are-supposed-to-be-saved/26810/2

@LaurenWags
Copy link
Member

Reproduced on macOS using 0.23.19

@Brave-Matt
Copy link

+1 from Reddit https://www.reddit.com/r/brave_browser/comments/8v6wld/brave_always_asks_me_to_save_any_file_with_a/

@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jul 3, 2018
@eljuno
Copy link
Contributor Author

eljuno commented Jul 3, 2018

+1 from Twitter https://twitter.com/voxtis/status/1014232259996422144

@NejcZdovc
Copy link
Contributor

+1 from me

@srirambv
Copy link
Collaborator

srirambv commented Jul 5, 2018

+1 from https://community.brave.com/t/downloads-asking-location-every-time/27062/2

@eljuno
Copy link
Contributor Author

eljuno commented Jul 8, 2018

+1 from Reddit https://www.reddit.com/r/brave_browser/comments/8x4flc/turning_off_always_ask_where_to_save_files_doesnt/

@bsclifton
Copy link
Member

@jumde @darkdh I suspect this is related to the safe browsing changes. Would either of you be able to look at this?

@jumde jumde self-assigned this Jul 10, 2018
@bbondy
Copy link
Member

bbondy commented Jul 10, 2018

@jumde since this won't be turned on in muon before brave-core comes out, let's just backout of muon please. Thanks!

@jumde jumde mentioned this issue Jul 11, 2018
Merged
This was referenced Jul 21, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jul 23, 2018 •
edited by btlechowski
Loading

Verified on Windows x64 with
• 0.23.70 e63c780
• Muon 8.0.1
• libchromiumcontent: 68.0.3440.68

Verified with macOS 10.12.6 using

  • 0.23.70 e63c780
  • Muon 8.0.1
  • libchromiumcontent 68.0.3440.68

Verified on Ubuntu 17.10 x64

  • 0.23.70 e63c780
  • Muon 8.0.1
  • libchromiumcontent 68.0.3440.68

@kjozwiak kjozwiak mentioned this issue Jul 31, 2018
Closed
@RobinOehler RobinOehler mentioned this issue May 6, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jumde jumde

Labels
0.23.x issue first seen in 0.23.x bug feature/download needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/not-blocking release-notes/include
Projects
None yet
Milestone
0.23.x Release 4 w/ Chromium 68 (Rele...
Development

No branches or pull requests