Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Qwant Issues in Brave (Muon) #15229

Closed
jonathansampson opened this issue Sep 25, 2018 · 2 comments
Closed

Qwant Issues in Brave (Muon) #15229

jonathansampson opened this issue Sep 25, 2018 · 2 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Sep 25, 2018

Test plan

See #15230

Description

Qwant attempts to use unsupported extension-related APIs, and offers Firefox addons to Brave users.

Steps to Reproduce

Visit https://(www|lite).qwant.com in Brave (Muon). On www… you'll see an extension panel at the top-right of the page. Clicking this will blur the page, causing it to become unusable. On lite… you'll see an addon (for Firefox) offered at the top-right of the page.

Expected result:
Neither should be shown in Brave (Muon)

Reproduces how often:
100%

Reproducible on current live release:
Yes

Additional Information

The extension offering doesn't apply to brave-muon. When the user clicks the [x] to close the panel, www.qwant.com calls ExtensionHelper.closePopin. This creates a key "closedExtPanel" in Local Storage with a value of Date.now().

@bsclifton
Copy link
Member

Screen cap of the extension offer:
screen shot 2018-09-28 at 1 24 20 pm

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Oct 5, 2018

Verified on Linux x64

  • 0.25.0 907c7e4
  • Muon 8.1.8
  • libchromiumcontent 69.0.3497.100

Verified with macOS 10.12.6 using

  • 0.25.0 907c7e4
  • Muon 8.1.8
  • libchromiumcontent 69.0.3497.100
  • verified not offered add on for either clean profile (0.25.0) or upgrade profile (0.24.0->0.25.0)

Verified on Windows x64

  • 0.25.2 8ea2a9c
  • Muon 8.1.8
  • libchromiumcontent 69.0.3497.100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants