Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed context menu subitems display when the window is small #1589

Closed
ghost opened this issue May 6, 2016 · 10 comments
Closed

Fixed context menu subitems display when the window is small #1589

ghost opened this issue May 6, 2016 · 10 comments

Comments

@ghost
Copy link

ghost commented May 6, 2016

Original title: Y position of context menu subitems is wrong when overflowed
Bookmark submenu expansion bug

Test plan

#7661 (comment)

  1. Launch Brave and minimize your browser window as far as possible
  2. Click the kabob menu
  3. Scroll the menu with your mouse and keyboard to ~1/3 from the bottom
  4. Select "Bookmark" submenu
  5. Items should line up. It should NOT look like this (image courtesy of @luixxiul):
    submenu

Original issue description

Hello Dev team,

today i saw the following bug happening on the bookmark toolbar menu.
When i open a submenu it will appear way up , you can see that in the following screen shot:

OS : windows 7 64bit SP1
Brave : 0.9.3

bookmarkissue

@ghost
Copy link
Author

ghost commented May 6, 2016

Just to add , this does not happen on all existing submenus , it will happen in a random amount , some of them may work correctly but the others no.

@luixxiul
Copy link
Contributor

Still reproducible?

@ghost
Copy link
Author

ghost commented May 22, 2016

@luixxiul yep still reproducible , just updated to 0.10.0 64 bit

system-template

@luixxiul
Copy link
Contributor

luixxiul commented May 22, 2016

I'm trying but cannot reproduce it.. Would you please tell me how many bookmarks are in the left pulldown?

@ghost
Copy link
Author

ghost commented May 22, 2016

@luixxiul i have in that folder 191 items , 29 of them are folders and they are in the middle way of the folder.
i have imported these bookmarks from firefox so maybe you can do it that way.

@ghost
Copy link
Author

ghost commented May 22, 2016

@luixxiul i can give you a remote access to my machine incase you want to see it for yourself , let me know if thats required.

@luixxiul
Copy link
Contributor

I'll try by myself and will ask you if I need it, thanks.

@ghost
Copy link
Author

ghost commented May 22, 2016

@luixxiul sure

@luixxiul
Copy link
Contributor

I think I can reproduce the error consistently.

STR:

  1. Minimize your browser window as far as possible
  2. Click the kabob menu
  3. Scroll the menu with your mouse and keyboard to ~1/3 from the bottom
  4. Select "Bookmark" submenu

submenu

@bsclifton what do you think?

@luixxiul luixxiul added this to the Backlog milestone Feb 11, 2017
@bsclifton
Copy link
Member

@luixxiul looks like great repro steps 👍

@luixxiul luixxiul added feature/context-menu and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Mar 13, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.13.6, Backlog Mar 13, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2017
Resolves brave#7403 brave#7662 brave#1589

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 26, 2017
Resolves brave#7403 brave#7662 brave#1589

Auditors: @bsclifton

Test Plan:
- specified in the issue brave#7403
@bsclifton bsclifton changed the title Bookmark submenu expansion bug Y position of context menu subitems is wrong when overflowed Apr 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.