Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Back button stops working #180

Closed
garvankeeley opened this issue Jan 17, 2016 · 4 comments · Fixed by #232
Closed

Back button stops working #180

garvankeeley opened this issue Jan 17, 2016 · 4 comments · Fixed by #232
Assignees

Comments

@garvankeeley
Copy link
Contributor

STR: not sure what I did to cause this
Video shows back button not working as i go to 3-4 different links

@garvankeeley
Copy link
Contributor Author

out

@bbondy
Copy link
Member

bbondy commented Jan 17, 2016

just noting, can't repro with playing around with it. Will keep an eye out but if anyone has consistent exact STR please post.

@diracdeltas
Copy link
Member

@garvankeeley for future reference, might help to open browser console (cmd + shift + j) and screenshot the error log as well. 👍 for cool gif screenshot

@jiangyang
Copy link
Contributor

Run into this too. The console error points to this.activeFrame.goBack() where this.activeFrame is undefined, same for the forward button. One way to repro is to open 2 tabs, clicks to close one of the tabs and the remaining tab's back/forward would break.

The reason seems to be that clicking the tab close button also triggers the tab to be set active so eventually the closed tab is set to active. Attempted a fix here #222

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants