Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Two-finger swipe gesture on macOS should have visual indicator #2477

Closed
tcr opened this issue Jul 13, 2016 · 7 comments
Closed

Two-finger swipe gesture on macOS should have visual indicator #2477

tcr opened this issue Jul 13, 2016 · 7 comments

Comments

@tcr
Copy link
Contributor

tcr commented Jul 13, 2016

Describe the issue you encountered: The two-finger swipe gesture on macOS has no visual indication as you perform the swipe of whether it is activated (or will succeed). This may be intended but feels nonintuitive.

Expected behavior: Chrome has a visual arrow on the sides that appears as you swipe. Safari has a "page sliding" animation to indicate a swipe. Because Brave's swipe is calculated by velocity, a different type of indicator may be needed.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.0dev
  • Steps to reproduce:
    1. Open any page with a back history.
    2. Perform a two-finger swipe backward.
    3. See no visual changes.
@alexwykoff
Copy link
Contributor

+1 from support : https://linkbubble.zendesk.com/agent/tickets/6131

@luixxiul luixxiul added this to the Backlog milestone Jan 6, 2017
@ksmithut
Copy link

Along these lines, is there a way to disable swipe navigation altogether? I have disabled it in my system settings but Brave seems to be the only one that doesn't respect that setting.

@cndouglas
Copy link

@ksmithut We have an issue for that: #5907.

@alexwykoff
Copy link
Contributor

alexwykoff commented Jun 29, 2017

darkdh added a commit that referenced this issue Jun 29, 2017
with swipe progress indicator

fixes #9615 #2477

Auditors: @cezaraugusto, @bbondy, @bradleyrichter

Test Plan:
1. Adjust swipe navigation distance setting in
about:preferences#advanced
2. And swipe to navigate by different settings

It shouldn't show up on linux and window
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 25, 2017

Implemented in #9617

@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Developer Channel), Backlog Aug 25, 2017
@LaurenWags
Copy link
Member

@darkdh @NejcZdovc I'm seeing the back/forward arrows get larger when swiping up/down on a page, this this expected? cc @kjozwiak

swipe

@darkdh
Copy link
Member

darkdh commented Dec 17, 2017

Because you can't have 0 x-axis changes when you do vertical scroll. You will always have slightly horizontal movement which will be reflected onto the animation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants