data-l10n-id and translation

[luixxiul]

Describe the issue you encountered:
The strings in data-l10n-id appear in UI in English while they were translated. For example <label data-l10n-id='nameField' htmlFor='bookmarkName' /> in addEditBookmark.js shows Title:, even though it has been translated and the language is set to other than English on about:preferences.

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?): Both Windows 10 and OS X
• Brave Version: 0.11.1
• Steps to reproduce:
  1. Change language in other languages than English
  2. Try bookmarking a page
• Screenshot if needed:
• Any related issues: Localization tracking bug #1858

[luixxiul]

Also,

• download toolbar
• password notification
• noscript dialog
• siteinfo dialog
• "Remember this decision"
• Some strings on hamburger menu

etc. appear in English.
Menubar and context menu have been successfully translated.

Edit: there are some strings in the hamburger menu which have been translated but not applied due to the bug.

[bbondy]

Would like this soon but moving to 0.11.3 for now. @luixxiul pls revolt if this was working on a previous version of Brave.

[bbondy]

@aekeus some parts of the UI isn't being translated, changing the language in the html file des seem to translate to that language though. Could you take a look at this one?

[aekeus]

Sure thing

[aekeus]

After some investigation it seems all components are affected by this issue. It seems like only the default locale is being loaded. Console output:

[91167:0812/115126:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR
[91168:0812/115126:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR
[91171:0812/115126:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR
[91164:0812/115127:INFO:CONSOLE(93)] "Set up extension URL router.", source: chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/extension-router.js (93)
[91172:0812/115127:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR
[91173:0812/115128:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR
[91198:0812/115147:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale fr_FR

#2456

[aekeus]

The defaultLanguage meta attribute in index.html is overriding the currently selected language. navigator.language is correctly set to 'fr-FR'.

<meta name="defaultLanguage" content="en-US">

[bbondy]

Fixed thanks to Aubrey, BrianJ too.