Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improve startup time #3025

Closed
bbondy opened this issue Aug 7, 2016 · 36 comments
Closed

Improve startup time #3025

bbondy opened this issue Aug 7, 2016 · 36 comments
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. hackathon Legacy label for a hackaton. initiative/perf perf priority/P2 Crashes. Loss of data. Severe memory leak. project-tracking

Comments

@bbondy
Copy link
Member

bbondy commented Aug 7, 2016

Using console.time and console.timeEnd figure out why our startup time isn't ideal and find ways to improve it by lazily loading the slow things. Or see what we can wait until a few seconds into the app is started to init.

@luixxiul luixxiul added the perf label Sep 28, 2016
@luixxiul luixxiul added this to the 1.1.0 milestone Oct 30, 2016
@alexwykoff
Copy link
Contributor

+1 from support : https://linkbubble.zendesk.com/agent/tickets/6457

@srirambv
Copy link
Collaborator

+1 from support: https://linkbubble.zendesk.com/agent/tickets/6707

@bbondy
Copy link
Member Author

bbondy commented Nov 14, 2016

@bbondy
Copy link
Member Author

bbondy commented Nov 14, 2016

+1 from support: https://linkbubble.zendesk.com/agent/tickets/6573

@cezaraugusto
Copy link
Contributor

+1 from support: https://linkbubble.zendesk.com/agent/tickets/5622

@cndouglas
Copy link

cndouglas commented Nov 19, 2016

+1 from #5677.

@cndouglas
Copy link

UI suggestion: #5820

@luixxiul
Copy link
Contributor

luixxiul commented Jan 2, 2017

FWIW: electron/electron#5672

@bsclifton
Copy link
Member

Also see atom/atom#13253

We can share details with upstream in https://github.com/electron/maintainers-private/issues/32

@Renegilo
Copy link

There is still the problem of Brave's slow startup that doesn't seem to have been fixed since milestone 1.1.0. Its becoming my favorite browser, I'm I'm finding myself opening Firefox or Edge while waiting for it to start. And by the time Brave starts the other mentioned browser has already open and reached the the site I needed. The current version I am now using is
Name Version
Brave 0.12.15
Muon 1.4.31
libchromiumcontent 53.0.2785.143
V8 5.3.332.47
Node.js 6.5.0
Update Channel dev
os.platform win32
os.release 10.0.14393
os.arch x64

@luixxiul
Copy link
Contributor

have been fixed since milestone 1.1.0.

Because it's the milestone in a future.

@aekeus
Copy link
Member

aekeus commented Jan 25, 2017

Will instrument with #6267

@alexwykoff alexwykoff modified the milestones: 1.0.0, 1.1.0 Mar 8, 2017
@srirambv
Copy link
Collaborator

srirambv commented May 4, 2017

@Jacalz
Copy link
Contributor

Jacalz commented May 14, 2017

@bsclifton
Copy link
Member

+1 from #9596

@Miyurz
Copy link

Miyurz commented Jul 5, 2017

This is still an issue. Do we know which release is going to fix this ?

@bsclifton
Copy link
Member

bsclifton commented Jul 6, 2017

@Miyurz this is something we'd definitely love to improve. Unfortunately, I can't give a date. You can track some of our performance issues (including this one) with #9311

@eljuno
Copy link
Contributor

eljuno commented Jul 28, 2017

+1 from community

@NejcZdovc NejcZdovc added the hackathon Legacy label for a hackaton. label Jul 28, 2017
@ghost ghost added the Epic label Sep 12, 2017
@ghost
Copy link

ghost commented Sep 12, 2017

Converted this issue to an Epic so we can start tracking specific issues inside this one.

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Sep 18, 2017

Per @zentagonist request, I'm typing down what we could cover with this. The plan is to split this issue most we can so it's measurable.

  • Remove task-specific calls for unneeded features in start-up time (does ledger needs to be called at init time?)
  • Lazy-load task-specific calls likely to be used first once the app is ready (such as suggestions and bookmarks)
  • Improve the initial loading experience. Measure with metrics for first paint and first meaningful paint.
  • If all else fails, i.e. a feature that could not be removed at first content load (like punycode?), reduce call cost for long task operations by replacing them with faster methods

@NejcZdovc please add notes here based on your research if there's something more we should cover. Plan is to split this into several sub-tasks so that's achievable and not stale based on many issues to be covered

also related to this issue #8128

@MacStasy
Copy link

Any update on the status of the fix?

@bsclifton
Copy link
Member

bsclifton commented Feb 14, 2018

Great perf win by @ayumi which needs some additional work before we can accept it (if anyone is interested in checking out the hooks): #11962

@srirambv
Copy link
Collaborator

@NumDeP
Copy link

NumDeP commented Mar 24, 2018

+1

@LaurenWags
Copy link
Member

@srirambv
Copy link
Collaborator

@srirambv
Copy link
Collaborator

This should be fixed with brave-core but still needs tracking on brave-core once brave specific features are implemented.

@srirambv srirambv added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Jul 20, 2018
@srirambv
Copy link
Collaborator

+1 by @Xenios91 via brave/brave-browser#620

@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@nisc
Copy link

nisc commented Aug 22, 2018

Latest release from 14 days ago takes ca. 20 seconds to load on a modern Windows notebook with SSD. Chrome takes around 1 second on the same machine. Has this been fixed in brave-core yet?

Brave: 0.23.79
V8: 6.8.275.24
rev: 51b4905
Muon: 8.0.7
OS Release: 6.3.9600
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 68.0.3440.84

@bsclifton
Copy link
Member

bsclifton commented Aug 23, 2018

@nisc did you want to give it a shot? You can try one of our releases available here:
https://github.com/brave/brave-browser/releases

I'm able to open 0.54.0 on Windows in just under 3 seconds

Closing as I believe this is addressed with brave-core

@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 23, 2018
@nisc
Copy link

nisc commented Aug 25, 2018

@bsclifton 0.54.1 reduces startup time by ~80% to ~4 seconds on my machine. Much better than the >20 seconds in the stable release. Still not as fast as Chrome. But fast enough to be useful in production. This can stay closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. hackathon Legacy label for a hackaton. initiative/perf perf priority/P2 Crashes. Loss of data. Severe memory leak. project-tracking
Projects
None yet
Development

No branches or pull requests