Can't enable "Web notifications" on twitter

[joneschrisg]

Did you search for similar issues before submitting this one?

Yes.

Describe the issue you encountered:

Can't enable "Web notifications" on twitter.

Expected behavior:

Web notifications are enabled after tapping "Turn on" button; see STR below.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  OS X 10.11.6
• Brave Version:
  0.11.5
• Steps to reproduce:
  1. Navigate to Twitter Settings, then "Web notifications" subsection.
  2. Tap "Turn on" button
• Screenshot if needed:
• Any related issues:

[joneschrisg]

Same behavior in 0.11.6.

[bbondy]

/cc @diracdeltas

[luixxiul]

The config page says "web notifications settings are currently disabled" for me.

[diracdeltas]

@luixxiul do you see any permission for Twitter domains in about:preferences#security?

[alexwykoff]

Confirmed this is not working:

No special permissions existed for Twitter domains in about:preferences#security

I believe this also caused : #3877

[diracdeltas]

#3877 is definitely unrelated to 08e6191, but web notifications won't work anyway because of it

[bridiver]

this is going to require some larger changes. Electron's somewhat odd permission handling doesn't cover this case and we really should migrate to HostContentSettingsMap

[bbondy]

moving to 0.12.2

[bridiver]

The issue is caused by the way electron handles permissions. Everything is initially granted and the actual allow/deny decision is made in the cancel callback. This causes problems for setting detection both in twitter and in https://www.browserleaks.com/geo
As mentioned above, I think the best solution is to move away from the default electron handling and use HostContentSettingsMap and implement GetPushMessagingService in BraveBrowserContext so we can still return permissions synchronously and only trigger the permission callback when CheckPermissionOnIOThread returns ASK

[diracdeltas]

This seems to be fixed now? On OS X web notifications are appearing for me in 0.12.3

[bridiver]

maybe twitter changed something? Either way I think we want to either keep this open or open a new ticket because there we are not handling some calls correctly and really can't the way electron works right now

[luixxiul]

Closing as fixed. Let's reopen if we see the issue again 👍