Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

padding-left should be added to the back button #4624

Closed
luixxiul opened this issue Oct 8, 2016 · 2 comments
Closed

padding-left should be added to the back button #4624

luixxiul opened this issue Oct 8, 2016 · 2 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 8, 2016

Describe the issue you encountered: padding-left should be added to the back button.

clipboard01

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.4
  • Any related issues:

wdyt, @bradleyrichter ?

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Oct 8, 2016
@bsclifton
Copy link
Member

Related to #4622

The padding was to the left of both the menu and the nav buttons. We can restore the padding for just the nav buttons (would be a super easy change; it was 5px before). Let me know 😄

@bsclifton
Copy link
Member

bsclifton commented Oct 8, 2016

I just noticed right now (great job capturing it in the screenshot, @luixxiul)- the padding missing when back button is hovered definitely looks wrong

Here's a before/after of adding 5px back (this time only in front of the back/forward buttons)

before 😢
image

after 😄
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

3 participants