Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

color of div#window.frameless should be lighter? #4648

Closed
luixxiul opened this issue Oct 10, 2016 · 3 comments
Closed

color of div#window.frameless should be lighter? #4648

luixxiul opened this issue Oct 10, 2016 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-Win64 suggestion
Milestone

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: I'm wondering if the color of .platform--win32 div#window.frameless should be lighter. Here's a comparison between the current version and the ligher version (color: #888).

clipboard01
clipboard02

I prefer the below. What do you think, @bradleyrichter ?

If it is ok, I think this should be enabled only for Windows 10 if possible, as the current border color on Windows7 looks like the same as the default one.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.4
  • Any related issues:
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. OS/Windows suggestion labels Oct 10, 2016
@bsclifton
Copy link
Member

We could definitely make this lighter... the problem is, the color used for the border on Windows 10 depends on your own custom theme. By default, it's a blue color... but you can change to whatever you like (including change to match background color; and you might have your background as a slideshow)

@luixxiul
Copy link
Contributor Author

Thanks @bsclifton! Do you think it would be possible for us to make the value to be changed automatically based on the theme? The value seems to be hard-coded for now here:

border: 1px solid #000;

@bsclifton bsclifton added this to the 0.12.6dev milestone Oct 10, 2016
@bsclifton
Copy link
Member

Per discussion with @bradleyrichter, maybe we can do the following:
On Windows 10:

  • Border color can be #2283d3 (default blue color) when window has focus
  • Border color can be #aaaaaa when the window loses focus / blurred

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. OS/Windows QA/checked-Win64 suggestion
Projects
None yet
Development

No branches or pull requests

3 participants