Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Support optional Widevine for the ability to use Netflix #468

Closed
bridiver opened this issue Jan 30, 2016 · 36 comments
Closed

Support optional Widevine for the ability to use Netflix #468

bridiver opened this issue Jan 30, 2016 · 36 comments

Comments

@bridiver
Copy link
Collaborator

Netflix will play on Safari without Silverlight or Flash, but it does not appear to be working on Brave. Might be user-agent related?

@bbondy
Copy link
Member

bbondy commented Jan 30, 2016

Seems likely it would be easy to support different user agents per domain, probably best integrated into the SiteHacks module.

@bbondy
Copy link
Member

bbondy commented Jan 30, 2016

@m14t
Copy link

m14t commented Feb 11, 2016

Here's a screen shot of what I see when attempting to view a video in Brave (without using any SiteHacks):

screen shot 2016-02-10 at 7 10 56 pm

The help center link, https://help.netflix.com/support/27451, suggests updating the WideVine (a Google company for DRM video) component, by going to chrome://components/, but that url does not work in Brave.

@bbondy
Copy link
Member

bbondy commented Feb 15, 2016

Played with user agent strings a bit:
iPad Safari: Asks you to get the app
Safari OSX: Asks you for silverlight
Chrome / Windows UA: Asks you to get silverlight plugin
Firefox / Windows: Sends you to enable DRM page on Mozilla support: https://support.mozilla.org/en-US/kb/enable-drm

Pepper support could be added here: electron/electron#2085

@bridiver
Copy link
Collaborator Author

@bbondy did you try desktop safari? It works for me and I don't have any plugins

@bbondy
Copy link
Member

bbondy commented Feb 16, 2016

it asks for silverlight with a simple UA change. Interesting that it works for you on safari without it though.

@bbondy
Copy link
Member

bbondy commented Feb 16, 2016

If there is some content that is not DRM'ed the Firefox UA w/ windows would give the HTML5 player that would work in those cases.

@vurstp
Copy link

vurstp commented Apr 4, 2016

Experiencing the same issue as m141

@NeonskyDev
Copy link

I've gotten it to work on os x, Widevine and Flash on everything.

line 102 - frame.js
this.webview.setAttribute('plugins', 'true')
This is what i used to make the webview always have plugins, after that its just a matter of adding in the proper plugins and app.commandLine.appendSwitch.

I also for safe measures added
plugins: true
to appStore.js lines 124 and 215

If you'd like to see what i did for my app.commandLine i'd be happy to share :)
I managed to do all this without rebuilding electron or anything, just adding a few lines of code to the current files that brave is using.

@bridiver
Copy link
Collaborator Author

bridiver commented Apr 7, 2016

Thanks @MegaUber! I think the issue around Widevine is distribution. I believe it works if you already have it installed (with Chrome), but if not I think it has to be manually installed right now. I know Widevine is free to use, but we need to be sure that we won't be liable for distribution license fees (which can likely be avoided by downloading on install vs bundling). Do you want to submit a PR?

@NeonskyDev
Copy link

Here is a link to a gist i put together that might or might not help if i did this right lol
and I'm sorry I'm kind of new to actually well sharing on github, what is PR?

Widevine && PepperFlash

@bbondy
Copy link
Member

bbondy commented Apr 8, 2016

Very helpful, thanks @MegaUber !
Given the gist you posted I'm going to mark this as good first bug for now in case someone wants to turn it into a pull request. We could do this task in parts.

@jneumann
Copy link

jneumann commented Apr 9, 2016

I just submitted a PR for this. #1293

@luixxiul
Copy link
Contributor

Should this be closed or not yet?

@iangelov
Copy link

iangelov commented Jul 3, 2016

Still very much an issue. One could use the experimental Flash support, but that's clearly undesirable (I yearn for the day in which we could get rid of it for good).

@ghost
Copy link

ghost commented Jul 13, 2016

I am Brazilian and I would like you to help me in this problem .. I can not in any way implement Widevine in browswer. My twitter @EuNlope

@ghost
Copy link

ghost commented Aug 4, 2016

Alguém pode mandar a linha de código pra mim por gentileza? Someone can have the line of code for me please?

@mattapperson
Copy link

Still a major issue with amazon prime video too

@bbondy bbondy added this to the 0.12.7dev milestone Oct 25, 2016
@bbondy
Copy link
Member

bbondy commented Oct 25, 2016

First visit to Netflix:
screenshot 2016-10-25 00 52 07

After clicking on open preferences:
screenshot 2016-10-25 00 52 36

To install just click the switch.

Trying to view a vide on Netflix after that:
screenshot 2016-10-25 00 53 26

Working Netflix via Wideivne:
screenshot 2016-10-25 00 53 58

@bbondy
Copy link
Member

bbondy commented Oct 25, 2016

Redoing screenshot play by play w/ Windows:

First encounter on Netflix:
screenshot 2016-10-25 01 02 07

After clicking on "Open Preferences":
screenshot 2016-10-25 01 02 34

After clicking the switch to on to install:
screenshot 2016-10-25 01 02 41

Next load on Netflix, per site allow:
screenshot 2016-10-25 01 04 08

After the per site allowed:
screenshot 2016-10-25 01 03 54

@ghost
Copy link

ghost commented Oct 25, 2016

At last brought this to the browser .. Let's see how it behaves with the adoption of this plugin.

@jaydson
Copy link

jaydson commented Oct 29, 2016

I'm running Brave 0.12.7 on Ubuntu 16.10 and I don't have the option "Enable Google Widevine support" on my Security panel.
Is Google Widevine available for Linux?
Well, as far as I can see, Linux users can't use Netflix on Brave yet.

@BrendanEich
Copy link
Member

@jaydson we got the Google blobs for Win and Mac in time for 0.12.7 but Linux is different. @bbondy can say more, but should have it in next release.

@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

probably not next release but soon, and tracking it here:
#5282

@kirkins
Copy link

kirkins commented Aug 25, 2017

Any updates on the linux release?

@bbondy
Copy link
Member

bbondy commented Sep 2, 2017

This is working and will be shipped in the release next week.
@darkdh and @bsclifton are the heros of the work :)

@bsclifton
Copy link
Member

@kirkins our Linux support is tracked with #5282 which I believe @posix4e is working on 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests