Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket: Support ContentMenu Methods #4689

Closed
jonathansampson opened this issue Oct 11, 2016 · 0 comments · Fixed by #5172
Closed

Pocket: Support ContentMenu Methods #4689

jonathansampson opened this issue Oct 11, 2016 · 0 comments · Fixed by #5172
Assignees
@darkdh
Labels
feature/extensions
Milestone
0.12.8dev

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 11, 2016 •
edited
Loading

Describe the issue you encountered:
The remove, removeAll and create methods of chrome.contentMenus are unsupported. As a result, some extensions cannot rely on these to provide crucial functionality.

Expected behavior:
Extensions can use the remove, removeAll and create methods of chrome.contentMenus to provide crucial functionality to the end-user.

See setupRightContext and setupExtensionModificationListeners.

  • Platform: Windows 10
  • Brave Version: 0.12.4

Repro Steps:
https://github.com/jonathansampson/browser-laptop/tree/ext_pocket
This was referenced Oct 11, 2016
Closed
Closed
@bsclifton bsclifton added this to the 0.12.6dev milestone Oct 11, 2016
@jonathansampson jonathansampson mentioned this issue Oct 12, 2016
Closed
@bbondy bbondy modified the milestones: 0.12.7dev, 0.12.6dev, 0.12.8dev Oct 18, 2016
@darkdh darkdh self-assigned this Oct 24, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 26, 2016
@darkdh
Add chrome.contextMenus.create and chrome.contextMenus.removeAll
2aed8b3 
fix brave#4689

requires brave/muon#82

Auditors: @bridiver, @jonathansampson

Test Plan: n/a
@darkdh darkdh mentioned this issue Oct 26, 2016
Merged
4 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 27, 2016
@darkdh
Add chrome.contextMenus.create and chrome.contextMenus.removeAll
d602b3c 
fix brave#4689

requires brave/muon#82

Auditors: @bridiver, @jonathansampson

Test Plan: n/a
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/extensions
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Add chrome.contextMenus.create and chrome.contextMenus.removeAll darkdh/browser-laptop
4 participants
@jonathansampson @bbondy @bsclifton @darkdh