Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payment Button mouse over barely noticeable #4708

Closed
srirambv opened this issue Oct 12, 2016 · 10 comments · Fixed by #5916
Closed

Payment Button mouse over barely noticeable #4708

srirambv opened this issue Oct 12, 2016 · 10 comments · Fixed by #5916

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Payment Button mouse over barely noticeable

Expected behavior:
Keep the button color same across all pages.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.5 Preview 1
  • Steps to reproduce:
    1. Open payments page, Advance settings button mouse over is not noticeable
    2. Open Advance settings modal. Done button mouse over is barely noticeable
  • Screenshot if needed:
  • Any related issues:

cc: @jkup @bradleyrichter

@srirambv srirambv added this to the 0.12.5dev milestone Oct 12, 2016
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 12, 2016
@bbondy
Copy link
Member

bbondy commented Oct 12, 2016

moving to 0.12.6

@jkup jkup self-assigned this Oct 12, 2016
@jkup
Copy link
Contributor

jkup commented Oct 13, 2016

@srirambv the mouse cursor changes to pointer on these buttons though, right? Is this issue just that there isn't a noticeable color change? If so, maybe @bradleyrichter can weigh in?

@srirambv
Copy link
Collaborator Author

@jkup the mouse cursor changes but the on hover color change is not clearly noticeable. Keeping the all the button standardized(Orange button with on hover border) across about pages seems good to me. This way there will be uniformity across about pages.

@mrose17 mrose17 modified the milestones: 0.12.7dev, 0.12.6dev Oct 17, 2016
@jkup
Copy link
Contributor

jkup commented Oct 20, 2016

@bradleyrichter do you still have your original spec for how all buttons are supposed to look? If so, could you upload it here when you get a chance? Thanks!

@bradleyrichter
Copy link
Contributor

@jkup

image

@jkup
Copy link
Contributor

jkup commented Oct 20, 2016

@bradleyrichter thank you!

@luixxiul
Copy link
Contributor

@bradleyrichter Aren't labels of three *Dis buttons too light?

@bradleyrichter
Copy link
Contributor

@luixxiul We can adjust the total button opacity if legibility is a problem.

@mrose17 mrose17 modified the milestones: 0.12.8dev, 0.12.7dev, 1.1.0 Oct 22, 2016
@mrose17 mrose17 added the polish Nice to have — usually related to front-end/visual tasks. label Nov 22, 2016
@jkup
Copy link
Contributor

jkup commented Dec 1, 2016

@bradleyrichter will #5916 fix this issue as well?

@luixxiul
Copy link
Contributor

Test plan: #5916 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants