Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

contents of ledger recovery key text file should be set to the spec #4807

Closed
luixxiul opened this issue Oct 15, 2016 · 7 comments
Closed

contents of ledger recovery key text file should be set to the spec #4807

luixxiul opened this issue Oct 15, 2016 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 15, 2016

Describe the issue you encountered:
According to #3350 (comment) the contents of ledger recovery key text file should be like this:

Brave Wallet Recovery Keys
Date created: 08/12/16

Recovery Key 1: e0c455d3-8b8a-40da-9358-2c38ce380b80
Recovery Key 2: 73de0bee-31f3-40e9-9a01-0f27958d925a

Note: These keys are not stored on Brave servers. These keys are your only method of recovering your Brave wallet. Save these keys in a safe place, separate from your Brave browser.

For now the key file lacks the date created and the note. Also the keys should be labelled.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Oct 15, 2016

cc @jkup please handle for 0.12.6

@jkup
Copy link
Contributor

jkup commented Oct 16, 2016

@bbondy happy to, this must have gotten lost in the shuffle but I did have a question about how best to handle this. Right now the text that gets printed or saved is just a string in one of our properties files (https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/locales/en-US/app.properties#L129)

In order to make this to spec I'll need to add new line breaks. What's my best approach here? A bunch of strings (one for each line)?

Thanks!

@bradleyrichter
Copy link
Contributor

this is nice to have as the current implementation is lacking the friendly factor...

@bbondy
Copy link
Member

bbondy commented Oct 17, 2016

I think the string would just be an HTML string instead. Should be able to just use template strings to hack that together.

@mrose17 mrose17 modified the milestones: 0.12.7dev, 0.12.6dev, 0.12.8dev Oct 17, 2016
@mrose17
Copy link
Member

mrose17 commented Oct 25, 2016

when we do get around to addressing this issue, perhaps we can also deal with the line-wrap issue!

2

@jkup
Copy link
Contributor

jkup commented Oct 25, 2016

@mrose17 definitely. I think the line wrap should be an easy fix as there is only so long a key can be.

@luixxiul
Copy link
Contributor Author

Test plan: #5862 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants