Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Manually added bookmark pages doesn't create the favicons after visiting the site #4860

Closed
srirambv opened this issue Oct 17, 2016 · 3 comments · Fixed by #5484
Closed

Manually added bookmark pages doesn't create the favicons after visiting the site #4860

srirambv opened this issue Oct 17, 2016 · 3 comments · Fixed by #5484

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Manually added bookmark pages doesn't create the favicons after vising the site

Expected behavior:
Standard behavior is to load the favicon to the bookmark once the page is visited

  • Platform (Win7, 8, 10? macOS? Linux distro?):
  • Brave Version:
  • Steps to reproduce:
    1. Right click on the bookmarks toolbar and add a bookmark
    2. Newly added bookmark has the default blank page as favicon
    3. Visit the site the favicon still remains the same, doesn't update the favicons
  • Screenshot if needed:
    Brave v/s Chrome
    addbookmark
  • Any related issues:
@srirambv srirambv added this to the 0.12.6dev milestone Oct 17, 2016
@bbondy bbondy modified the milestones: 0.12.7dev, 0.12.6dev Oct 18, 2016
@bbondy bbondy changed the title Manually added bookmark pages doesn't create the favicons after vising the site Manually added bookmark pages doesn't create the favicons after visiting the site Oct 24, 2016
@bbondy bbondy modified the milestones: 0.12.8dev, 0.12.7dev Oct 24, 2016
@bsclifton bsclifton self-assigned this Oct 31, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Nov 3, 2016

Issue not fixed. Confirmed by @luixxiul . Reopening the issue
4860

cc: @bsclifton

@srirambv srirambv reopened this Nov 3, 2016
@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

Moving to 0.12.9

@bsclifton
Copy link
Member

bsclifton commented Nov 4, 2016

Root cause is that the URL isn't matching. The bookmark, when visited, is updated to have a trailing slash. This ends up not matching the bookmark. The bookmark URL should be normalized when updated/searched in our sites list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.