Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

View payment history link needs padding #4867

Closed
srirambv opened this issue Oct 17, 2016 · 3 comments
Closed

View payment history link needs padding #4867

srirambv opened this issue Oct 17, 2016 · 3 comments
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

View payment history link may use some padding.

image
@mrose17 mrose17 modified the milestones: 1.0.0, 0.12.7dev, 0.12.8dev Oct 17, 2016
@mrose17 mrose17 modified the milestones: 1.1.0, 0.12.8dev Oct 25, 2016
@bradleyrichter
Copy link
Contributor

it also needs ellipses...

@mrose17 mrose17 added polish Nice to have — usually related to front-end/visual tasks. and removed suggestion labels Dec 7, 2016
@luixxiul luixxiul mentioned this issue Dec 7, 2016
Merged
4 tasks
@luixxiul luixxiul modified the milestones: 0.13.0, 1.1.0 Dec 7, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Dec 7, 2016 •
edited
Loading

Pushed a PR to fix into

screenshot 2016-12-08 2 48 55

The link position has been fixed with #6009 already

The button padding issue has been addressed with 2616a84 of #6047

This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan:

1 Create the fake payment history following the steps described here: #4656 (comment)
2 Open about:preferences#payments
3 Make sure the link is placed under the monthly budget

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@mrose17 @luixxiul @bradleyrichter @srirambv