Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Setting Brave as default from the startup check on Linux doesn't work #4939

Closed
Sh1d0w opened this issue Oct 19, 2016 · 6 comments
Closed

Setting Brave as default from the startup check on Linux doesn't work #4939

Sh1d0w opened this issue Oct 19, 2016 · 6 comments
Assignees
Milestone

Comments

@Sh1d0w
Copy link

Sh1d0w commented Oct 19, 2016

Clicking on "Use Brave" does not work at all under Linux (Fedora 24 and Ubuntu). Also if I manually set Brave as default browser the check popup still appears, despite the fact that Brave is my default browser.

In order to implement this please see the man page for xdg-mime https://linux.die.net/man/1/xdg-mime

To check if brave is the default browser on the system:

xdg-mime query default text/html 
xdg-mime query default x-scheme-handler/http
xdg-mime query default x-scheme-handler/https

If the output of these commands is not brave.desktop then to set is as default scheme handle do the following:

xdg-mime default brave.desktop text/html 
xdg-mime default brave.desktop x-scheme-handler/http
xdg-mime default brave.desktop x-scheme-handler/https

cc @bbondy @darkdh

@Sh1d0w Sh1d0w added this to the 0.12.6dev milestone Oct 19, 2016
@darkdh
Copy link
Member

darkdh commented Oct 19, 2016

@Sh1d0w which electron version do you have?

@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 19, 2016

@darkdh

@darkdh
Copy link
Member

darkdh commented Oct 19, 2016

@Sh1d0w you should upgrade it to at least 1.4.15+ which will contain brave/muon@016f564

@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 19, 2016

@darkdh Sorry. npm install downloads and installs electron 1.4.14, I did not know that I need 1.4.15 in order to this to work. Closing.

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

if your node_modules already exists and contains a ref to 1.4.14 I think it just re-installs that same version, I find just clearing node_modules before npm install works better. You can also use npm update electron-prebuilt and it might work.

@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 19, 2016

@bbondy Yes I learned that the hard way :D thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants