Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark titles getting renamed after import #5060

Closed
bsclifton opened this issue Oct 22, 2016 · 1 comment · Fixed by #5263
Closed

Bookmark titles getting renamed after import #5060

bsclifton opened this issue Oct 22, 2016 · 1 comment · Fixed by #5263

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Customer reports that when importing bookmarks from Chrome, items which had a custom title are getting renamed after visiting the site:

I imported all my bookmarks from Google Chrome (went fine), but visiting any of them causes Brave to automatically rename the bookmark (eg my "Daily Telegraph" link becomes "The Telegraph - blah blah blah 3 paragraphs long..."). Any way to stop this behaviour without my having to visit each site and rename it back to what it used to be?

Expected behavior:
The import process should set the title from Chrome as the customTitle

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all
  • Brave Version:
    all
  • Steps to reproduce:
    1. Launch Google Chrome and save a few bookmarks
    2. Rename those bookmarks with a meaningful name
    3. Launch Brave and import those bookmarks
    4. Visit the bookmark and notice the title gets updated
  • Screenshot if needed:
  • Any related issues:
@bsclifton
Copy link
Member Author

cc: @darkdh

@bsclifton bsclifton added this to the 0.12.8dev milestone Oct 22, 2016
@darkdh darkdh self-assigned this Oct 22, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 29, 2016
fix brave#5060

Auditors: @bsclifton

Test Plan:
1. Bookmark a page from other browser
2. Rename the bookmark in step 1
3. Import bookmakrs from the browser in step 1
4. Click the bookmark and it shouldn't be renamed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants