Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Images not loaded on Facebook.com when block ads is selected in shields #5151

Closed
srirambv opened this issue Oct 26, 2016 · 3 comments
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 26, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Images not loaded on Facebook.com when block ads is selected in shields

Expected behavior:
Should show pics when Adblock is enabled

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.7 Preview 1 (clean install)
  • Steps to reproduce:
    1. Enable block ads in Shields
    2. Visit Facebook.com, all images are blocked
    3. Disable block ads, all images are loaded
  • Screenshot if needed:
    image
  • Any related issues:
    Brave ad blocker affecting legitimate images #4442
@privatzee
Copy link
Contributor

privatzee commented Oct 26, 2016

because of blocking Facebook CDN at fbcdn.net: #5153
which is technically CORS

@privatzee
Copy link
Contributor

@srirambv Since this is FB, wouldn't this qualify as ultra-top priority? Times 1,000? :)

Btw, I see that you are not identified as 'Brave Software Member'

image
versus, e.g.:
image

Just letting you know, I don't mean to be intruding.

Also, one day I was looking around on the website issues, and IIRC it was mentioned that you should be on the website's about page... Okay, here it is: needs Sriram

@bbondy
Copy link
Member

bbondy commented Oct 26, 2016

This was fixed a couple hours ago and due to a Tracking Protection list update that was overly aggressive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants