Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

don't show blank urlbar for about:blank #5209

Closed
diracdeltas opened this issue Oct 27, 2016 · 0 comments · Fixed by #5214
Closed

don't show blank urlbar for about:blank #5209

diracdeltas opened this issue Oct 27, 2016 · 0 comments · Fixed by #5214
Assignees
@diracdeltas
Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 security
Milestone
0.12.8dev

Comments

@diracdeltas
Copy link
Member

this makes certain phishing attacks slightly harder since it's clear to the user that they are not on <legitimate-site>.com. matches chrome's behavior.
@diracdeltas diracdeltas added this to the 0.12.8dev milestone Oct 27, 2016
@diracdeltas diracdeltas self-assigned this Oct 27, 2016
diracdeltas added a commit that referenced this issue Oct 28, 2016
@diracdeltas
show about:blank in urlbar
0410323 
fix #5209

Auditors: @bbondy

Test Plan:
1. go to about:blank, observe that it is shown in the urlbar
2. highlight urlbar and go to about:newtab, observe that it is now empty
@diracdeltas diracdeltas mentioned this issue Oct 28, 2016
Merged
4 tasks
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 security
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

show about:blank in urlbar brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv