On new tab page, sometimes a topSite doesn't even have a letter

[cezaraugusto]

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
On new tab page, topSites displays site's first title letter as a fallback if it couldn't find any favicon. Sometimes a letter isn't even shown. It happened for this URL.

Expected behavior:
If there's no site's favicon, letters should always appear as fallback.

• Platform (Win7, 8, 10? macOS? Linux distro?): any

• Brave Version: n/a

• Screenshot if needed:
  

[bbondy]

Is there really no letter or maybe the favicon is the same color as the tile and is only 1 color?

[cezaraugusto]

Not easy to reproduce but it happened a few times. Yes, no letter and there's no favicon as well. Different from accessing like https://brianbondy.com where both themeColor and favicon share the same color.

Actually this bug was pointed by you on our old newtab's PR (#3199) and I confirmed a while after. Setting here just as a reference, can be closed if there's no new reports.

[bsclifton]

@bbondy @bradleyrichter would it be acceptable (if the title is blank) to use the first letter of the actual domain?

[bbondy]

up to @bradleyrichter maybe that would lead to a lot of W for www., if Brad wants this you could skip that prefix though.

[bradleyrichter]

sounds like a reasonable fallback

[bsclifton]

to be consistent with the history page, I was thinking we could just use the domain (not the subdomain)