Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension API: chrome.browserAction.setBadgeBackgroundColor #5367

Closed
jonathansampson opened this issue Nov 3, 2016 · 3 comments
Closed

Extension API: chrome.browserAction.setBadgeBackgroundColor #5367

jonathansampson opened this issue Nov 3, 2016 · 3 comments
Assignees
@jonathansampson
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Nov 3, 2016 •
edited by luixxiul
Loading

Test Plan:

#7050 (comment)

  1. Enable the LastPass extension
  2. From chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/tabDialog.html?dialog=createAccountSimple, open Developer Tools (Ctrl+Shift+I)
  3. If you have not, from console, run chrome.browserAction.setBadgeText({text:"27"})
  4. From console, run chrome.browserAction.setBadgeBackgroundColor({color:'#FF0000'})

Original issue description

Honey (and other extensions) may often communicate valuable information by way of badge icon background colors. Honey uses this API to indicate the presence of deals available for the domain.

Screenshot: (Left: Chrome, Right: Brave)
image

Documentation: https://developer.chrome.com/extensions/browserAction#method-setBadgeBackgroundColor

Related Issues: #5366, #5362
@jonathansampson jonathansampson changed the title Honey: Support chrome.browserAction.setBadgeBackgroundColor Honey: Support browserAction.setBadgeBackgroundColor Nov 3, 2016
@darkdh darkdh self-assigned this Jan 7, 2017
@jonathansampson jonathansampson mentioned this issue Feb 4, 2017
Merged
4 tasks
@bbondy bbondy added this to the 0.13.3 milestone Feb 5, 2017
@bsclifton bsclifton modified the milestones: 0.13.6, 0.13.5 Feb 23, 2017
@bsclifton
Copy link
Member

moving to 0.13.7

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 14, 2017
@darkdh darkdh assigned jonathansampson and unassigned darkdh Mar 28, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff changed the title Honey: Support browserAction.setBadgeBackgroundColor Added extension badge colors Apr 13, 2017
@alexwykoff
Copy link
Contributor

Could not reproduce on OS X.

@jonathansampson jonathansampson mentioned this issue Apr 17, 2017
Merged
4 tasks
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@jonathansampson jonathansampson changed the title Added extension badge colors Extension APIs: chrome.browserAction.setBadgeBackgroundColor May 4, 2017
@jonathansampson
Copy link
Collaborator Author

Blocked #8671

@jonathansampson jonathansampson mentioned this issue May 4, 2017
Closed
13 tasks
@jonathansampson jonathansampson changed the title Extension APIs: chrome.browserAction.setBadgeBackgroundColor Extension API: chrome.browserAction.setBadgeBackgroundColor Jul 3, 2017
@jonathansampson jonathansampson mentioned this issue Sep 16, 2017
Closed
78 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
8 participants
@jonathansampson @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @darkdh @srirambv