Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

The about screen should show the latest SHA hash #5462

Closed
bsclifton opened this issue Nov 7, 2016 · 6 comments
Closed

The about screen should show the latest SHA hash #5462

bsclifton opened this issue Nov 7, 2016 · 6 comments

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When running Brave, it can be hard to tell what version it is. Release candidates don't distinguish themselves clearly for example.

Expected behavior:
Users should be able to go to Help > About Brave on PC or Brave > About Brave on Mac and not only get Chromium versions, etc. But also get the last SHA that was included from browser-laptop.

The ideal solution would get the SHA and put it in a meaningful location during the build process (ex: when you run npm run build-package

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    All

  • Steps to reproduce:

    1. Install a release candidate of Brave
    2. From the menu, pick About Brave
    3. Notice it doesn't say this is a release candidate. How would you know?
    4. Be sad
  • Screenshot if needed:

  • Any related issues:

@bbondy
Copy link
Member

bbondy commented Dec 20, 2016

screenshot 2016-12-20 17 10 21

@srirambv
Copy link
Collaborator

This is on the latest master build on Windows 10 x64
image

cc: @bbondy @bridiver

@bbondy
Copy link
Member

bbondy commented Dec 28, 2016

@srirambv pls post a new issue in 0.13 and tag it windows only. Thanks!

@bsclifton
Copy link
Member Author

bsclifton commented Dec 28, 2016

This same behavior was originally the root cause for #6406

Logic was updated to get each field in a try/catch with #6410

@srirambv you should be able to see the error message in the console if you launch from command line. This should help us when you create the issue and tag as 0.13 😄

@srirambv
Copy link
Collaborator

Unable to repro after restarting from console. @bsclifton Last time it had the same console error reported in #6442.

After relaunching shows correct info
image

@luixxiul
Copy link
Contributor

Test plan:

Open about:about

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants