Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark icon is not properly aligned with URL Bar #5632

Closed
srirambv opened this issue Nov 15, 2016 · 7 comments
Closed

Bookmark icon is not properly aligned with URL Bar #5632

srirambv opened this issue Nov 15, 2016 · 7 comments

Comments

@srirambv
Copy link
Collaborator

url

cc: @jkup @bradleyrichter

@jkup
Copy link
Contributor

jkup commented Nov 15, 2016

Is this on master? And on Linux? I can't repro on my mac

@srirambv
Copy link
Collaborator Author

This is on the RC1 build and Ubuntu

@bbondy
Copy link
Member

bbondy commented Nov 15, 2016

moving to 0.12.10

@bbondy
Copy link
Member

bbondy commented Nov 15, 2016

Would love a fix and will put back in the milestone it's done in, but want to avoid more pixel bumping.

@bsclifton
Copy link
Member

@jkup this might be a good use-case for demo-ing a rev 1 of a "browser button" or similar type of Aphrodite control. Something simple that centers an SVG in the control.

Ultimately, this control could also be used for stop/reload and back/forward buttons (but without borders)

@luixxiul
Copy link
Contributor

I think I found a solution which depends on 214ce2d of #5737. I'm working on it.

@luixxiul
Copy link
Contributor

luixxiul commented Jan 16, 2017

Test plan: #5739 (comment)

Make sure #5739 has #5967 as a follow-up to remove the hacks for the URL bar on Windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.