Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New tab page shortcut buttons link tooltips are not user friendly #5657

Closed
cndouglas opened this issue Nov 16, 2016 · 4 comments
Closed

New tab page shortcut buttons link tooltips are not user friendly #5657

cndouglas opened this issue Nov 16, 2016 · 4 comments

Comments

@cndouglas
Copy link

cndouglas commented Nov 16, 2016

Test plan

#7771 (comment)


Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
Whenever I hover over a shortcut button in the new tab page, it shows a long and confusing link tooltip. It shows chrome-extension://<many random letters>/about:<page>.html, which appears to be some sort of internal link structure. This does not seem very user friendly.

The relevant source code is in browser-laptop/js/about/newTabComponents/footerInfo.js

Expected behavior:
The tooltip should either show the actual page link (e.g. "about:preferences") or nothing at all.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Found on macOS 10.12.x

  • Brave Version:
    0.12.9

  • Steps to reproduce:

    1. Open Brave and the new tab page.
    2. Hover over one of the shortcut buttons (e.g. preferences) in the bottom right corner.
    3. Look at the tooltip in the bottom left corner.
  • Screenshot if needed:
    image

  • Any related issues:
    None.

@cndouglas
Copy link
Author

Possibly similar to #5725 (urlbar is showing chrome-extension:// prefix for PDFs).

@bradleyrichter
Copy link
Contributor

@cezaraugusto Any easy fixes for this?

@bsclifton
Copy link
Member

I think this is going to be more complex than what @diracdeltas did with the above PDF change

We'd need to intercept the chrome://{extensionId} URL and then translate it to the proper about: page. What do you think, @diracdeltas?

@cezaraugusto
Copy link
Contributor

@bradleyrichter I think it's going to be a little more complicated than expected but doable for our 1.0.0 release imo.

@bsclifton bsclifton modified the milestones: 0.14.0, 1.0.0 Mar 19, 2017
@alexwykoff alexwykoff changed the title New tab page shortcut buttons link tooltips are not user friendly Fixed new tab page shortcut buttons link tooltips to be more user friendly Mar 28, 2017
@luixxiul luixxiul changed the title Fixed new tab page shortcut buttons link tooltips to be more user friendly New tab page shortcut buttons link tooltips are not user friendly Sep 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.