Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Swipe back on macOS #5907

Closed
luixxiul opened this issue Nov 29, 2016 · 14 comments
Closed

Swipe back on macOS #5907

luixxiul opened this issue Nov 29, 2016 · 14 comments
Labels
duplicate Issue has already been reported OS/macOS

Comments

@luixxiul
Copy link
Contributor

From support

I regularly find my web page going back to the previous in my history because it seems like Brave has introduced gestures and I'm accidentally swiping backwards on my touch pad.

Is it possible to make that a preference that can be switched off?

#2548

@darkdh
Copy link
Member

darkdh commented Nov 30, 2016

We will respect this system setting if user turn it off.
screen shot 2016-11-30 at 18 57 15
#2400

@pixelass
Copy link

I can confirm that it works with the system settings. It's the first thing I disable when I get a new macbook. Never had problems in the last two months of using brave.

@tcr
Copy link
Contributor

tcr commented Nov 30, 2016

They may be triggering this issue more often than intended: two-finger "back" can be triggered on horizontally scrolling elements, where in other browsers the element swallows the swipe.

@cndouglas
Copy link

I think the user in the support ticket wants an override setting for gestures in Brave. That way, the user can disable gestures in Brave only but leave gestures enabled in system preferences.

@ENDelt260
Copy link

Brave 0.13.0 on MacOS 10.12.3 does not appear to respect the system setting.

I have "Swipe between pages" disabled in my Mouse System Preferences, but Brave navigates my history w/ left/right swipes anyway.

@DocWatson
Copy link

Seeing the same issue as the poster above me, but I am on brave 0.13.2 and MacOS 10.11.6. I don't like/want this behavior, and would love for a way to disable it if the system settings cannot be used.

@d-fay
Copy link

d-fay commented Feb 9, 2017

I also would like the option to disable this feature within Brave. I disabled the gesture on my Mac trackpad settings and the gesture still works in Brave, but I would like it disabled.

@luixxiul luixxiul added this to the Backlog milestone Feb 9, 2017
@bsclifton
Copy link
Member

Per the above, it should be respecting the setting (on macOS)... cc: @darkdh

@darkdh
Copy link
Member

darkdh commented Feb 9, 2017

system preferences is removed because of chromium 54 upgrade changes(node removal)
https://github.com/brave/browser-laptop/blob/master/js/components/main.js#L257-L258

@luixxiul
Copy link
Contributor Author

@darkdh would you reset the milestone if you would work on this issue, thanks!

@benjaminkitt
Copy link

Just to reiterate, the swipe gesture should not trigger when scrolling horizontally. Using a wide Google Sheet for example is maddening because whenever you scroll to the left, you trigger the back swipe action.

@itslenny
Copy link

itslenny commented Mar 1, 2017

I regularly have this happen. It's incredibly sensitive sometimes I'm barely even scrolling when it happens. This happens to me multiple times every single day. It's gotten so frustrating that I have to stop using brave until it's fixed.

(Like many above I do have it disabled in system settings already)

@cndouglas
Copy link

Everyone with the accidental swipe problem: please see issue #7100 (Horizontal scrolling with two-finger gesture is also treated as page navigation).

@cndouglas
Copy link

I'm going to close this since we already have issues for the problems described here.

Back/forward gesture does not respect system preferences: #3299
Horizontal scrolling with two-finger gesture is also treated as page navigation: #7100

Please subscribe to those issues for further updates.

@cndouglas cndouglas removed this from the Backlog milestone Mar 18, 2017
@cndouglas cndouglas added the duplicate Issue has already been reported label Mar 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported OS/macOS
Projects
None yet
Development

No branches or pull requests