Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added a link to release notes in about:brave #6130

Closed
luixxiul opened this issue Dec 10, 2016 · 5 comments
Closed

Added a link to release notes in about:brave #6130

luixxiul opened this issue Dec 10, 2016 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 10, 2016

Old title: Add the release notes of the same version as the browser to about:brave #6130 (comment)

Test Plan

#7791 (comment)

  1. Open about:brave
  2. Should contain Browse faster and safer with Brave. below About Brave
  3. Should have a new section Release Notes
  4. Clicking on hyperlink should open GitHub release page

Original issue description

Expected behavior:
Add the release notes of the same version as the browser to about:brave. The release notes and release date which are specified in updater.js could be reused in some way.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

@luixxiul
Copy link
Contributor Author

CC @bradleyrichter for comments on design of the about page. Have you designed one already?

@bsclifton
Copy link
Member

bsclifton commented Dec 11, 2016

I like this; my ideal design (personal opinion) would be:

  • Nice high-res Brave logo next to the "About Brave" 🦁
  • Version information on top (below that)
  • Release notes below that

Some of the other information I've considered showing here (maybe a collapsed area which is expandable):

  • what command line params was Brave launched with?
  • video card information
  • other info that may be useful for troubleshooting

@bradleyrichter
Copy link
Contributor

Logo would be nice...

@luixxiul
Copy link
Contributor Author

I was trying to load https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/img/braveAbout.png in the brave.js and it seems that it does not let me use <img src=''>.. Is there any way instead of it?

@bsclifton
Copy link
Member

bsclifton commented Dec 14, 2016

@luixxiul because this image is inside the Brave extension itself, loading it is not straight-forward. You'll want to look at an example on the Payments UI for how to load internal images (ex: the CoinBase logo)

Trying to load the image above fails because of the content security policy

@luixxiul luixxiul added this to the contributor backlog milestone Dec 23, 2016
@luixxiul luixxiul modified the milestones: 0.14.2, contributor backlog Apr 4, 2017
@alexwykoff alexwykoff changed the title Add the release notes of the same version as the browser to about:brave Added a link to release notes in about:brave Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.