Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression : Alignment off for about:about #6183

Closed
alexwykoff opened this issue Dec 13, 2016 · 4 comments · Fixed by #6298
Closed

Regression : Alignment off for about:about #6183

alexwykoff opened this issue Dec 13, 2016 · 4 comments · Fixed by #6298
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.13.0

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Dec 13, 2016 •
edited by bbondy
Loading

Only reproducible with the PR from:
#5790 (comment)

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
Visiting about:about 'List of about pages' is flush left with no margin.

Expected behavior:
'List of about pages' should left-align under 'About pages' header.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on os x

  • Brave Version:
    0.12.15 RC2

  • Steps to reproduce:

    1. Visit about:about

  • Screenshot if needed:

screen shot 2016-12-13 at 11 24 29 am

  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.15 milestone Dec 13, 2016
@luixxiul
Copy link
Contributor

1597632#diff-1fcd5f7d89a2a38953d711aeb2e1dfeaL84 causes a regression.

Because siteDetails.less is used globally, actually the changes in the file with the commit should be reverted to set up a special file which is to be loaded only in about:brave.

1597632#diff-1fcd5f7d89a2a38953d711aeb2e1dfeaR81 would therefore cause a regression too.

@bbondy bbondy mentioned this issue Dec 13, 2016
Merged
4 tasks
@bbondy bbondy removed this from the 0.12.15 milestone Dec 13, 2016
@bbondy
Copy link
Member

bbondy commented Dec 13, 2016

resetting milestone since the PR that introduced it was reverted:
https://github.com/brave/browser-laptop/pull/6107/files

@bbondy bbondy mentioned this issue Dec 13, 2016
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Dec 13, 2016 •
edited
Loading

Also make sure every change in history.less would cause a regression because about:brave is for now based on that file.

@luixxiul luixxiul mentioned this issue Dec 13, 2016
Closed
4 tasks
@bsclifton bsclifton mentioned this issue Dec 19, 2016
Merged
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 19, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
cezaraugusto pushed a commit that referenced this issue Dec 20, 2016
@cezaraugusto
Redo: Add copy to clipboard for about brave page (fixes #5790)
fa425c0 
Closes #6183

Redo PR #6107 (which was reverted with #6184)

- cherry-picked 942e95c
- Added brave.less for about:brave to fix regression on about pages

TODO: Pick up properties from history.less into brave.less

Auditors: @alexwykoff

Test Plan:
1. Visit about:about
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan:

Open about:about

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Redo: Add copy to clipboard for about brave page (fixes #5790)
5 participants
@bbondy @alexwykoff @luixxiul @bsclifton @srirambv