Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

border-bottom of the table header of the payment history should be extended #6231

Closed
luixxiul opened this issue Dec 15, 2016 · 1 comment · Fixed by #6047
Closed

border-bottom of the table header of the payment history should be extended #6231

luixxiul opened this issue Dec 15, 2016 · 1 comment · Fixed by #6047
Assignees
@luixxiul
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 15, 2016 •
edited
Loading

Describe the issue you encountered:
According to #5719 (comment) border-bottom of the table header of the payment history should be extended to the the border of the dialog.

screenshot 2016-12-15 18 00 28

Expected behavior:
screenshot 2016-12-15 18 26 33
@luixxiul luixxiul added feature/rewards polish Nice to have — usually related to front-end/visual tasks. labels Dec 15, 2016
@luixxiul luixxiul self-assigned this Dec 15, 2016
@luixxiul luixxiul mentioned this issue Dec 15, 2016
Merged
4 tasks
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 15, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test Plan:

  1. Disable the ledger
  2. run npm run add-simulated-payment-history some times
  3. Enable the ledger
  4. Click "View Payment History..."
  5. Make sure the dialog like this appears:

screenshot 2016-12-15 3 36 37

@alexwykoff alexwykoff mentioned this issue Jan 17, 2017
Closed
This was referenced Jan 18, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Refactor about:preferences#payments followups
3 participants
@alexwykoff @luixxiul @srirambv