Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

default zoom level effects browser chrome UI and should not w/ C54 #6315

Closed
luixxiul opened this issue Dec 20, 2016 · 9 comments
Closed

default zoom level effects browser chrome UI and should not w/ C54 #6315

luixxiul opened this issue Dec 20, 2016 · 9 comments
Assignees
@bbondy
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude settings
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:
I think this has been captured by @alexwykoff at first, though I cannot find the issue where he mentioned this.

Default zoom change on about:preferences zooms in/out the UI

Expected behavior:

It should not zoom in/out the UI itself

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version: 0.13.0 Preview5

  • Steps to reproduce:

    1. Open about:prefrences
    2. Change the default zoom level to 95%
    3. Make sure the font-size on the menu bar changes to 95%

Be careful not to set it to 500% because it makes the UI completely unusable.

  • Any related issues:
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 20, 2016
@darkdh
Copy link
Member

darkdh commented Dec 20, 2016

This should be probably fixed by brave/muon@473fcd6

but I can't verify it with current commit due to other issues

@bbondy
Copy link
Member

bbondy commented Dec 20, 2016

Is this windows only?

@darkdh
Copy link
Member

darkdh commented Dec 21, 2016

Ah, sorry. It also happens on Mac.

@bbondy
Copy link
Member

bbondy commented Dec 22, 2016

@darkdh can this be closed?

@darkdh darkdh self-assigned this Dec 22, 2016
@darkdh
Copy link
Member

darkdh commented Dec 22, 2016

Can't be closed now. I'm working on it

@darkdh darkdh removed their assignment Dec 22, 2016
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 22, 2016
@bbondy bbondy added this to the 0.13.0 milestone Dec 22, 2016
@bbondy
Copy link
Member

bbondy commented Dec 22, 2016

Re-added 0.13.0 milestone, @luixxiul why was it removed?

@luixxiul
Copy link
Contributor Author

as the assignment was removed I thought it was postponed to fix this.

@bbondy bbondy self-assigned this Dec 23, 2016
@bbondy bbondy changed the title default zoom change on about:preferences zooms in/out the UI default zoom level effects browser chrome UI and should not w/ C54 Dec 23, 2016
bbondy added a commit to brave/muon that referenced this issue Dec 23, 2016
@bbondy
Support zoom limiting on webFrame
5a9e43c 
Auditors: @bsclifton

Electron side of the fix for brave/browser-laptop#6315
@bbondy bbondy closed this as completed in 7978dff Dec 23, 2016
@bbondy
Copy link
Member

bbondy commented Dec 23, 2016

Fixed!

This was referenced Dec 30, 2016
Closed
Closed
Closed
Closed
bsclifton pushed a commit to brave/muon that referenced this issue Dec 30, 2016
@bbondy @bsclifton
Support zoom limiting on webFrame
801ead5 
Auditors: @bsclifton

Electron side of the fix for brave/browser-laptop#6315
bbondy added a commit to brave/muon that referenced this issue Dec 30, 2016
@bbondy
Support zoom limiting on webFrame
b4ae045 
Auditors: @bsclifton

Electron side of the fix for brave/browser-laptop#6315
@luixxiul
Copy link
Contributor Author

Test plan: available on the 1st post.

@luixxiul luixxiul mentioned this issue Feb 2, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude settings
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @darkdh @srirambv