Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

opening a link in a new tab creates the new tab at the most left #6411

Closed
luixxiul opened this issue Dec 23, 2016 · 3 comments
Closed

opening a link in a new tab creates the new tab at the most left #6411

luixxiul opened this issue Dec 23, 2016 · 3 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 23, 2016

Describe the issue you encountered:
opening a link in a new tab creates the new tab at the most left, not next to the tab

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): f04777e

  • Steps to reproduce:

    1. Open any link by clicking it pushing the command key
  • Any related issues:

@luixxiul luixxiul changed the title opening a link in a new tab creates open the tab at the most left opening a link in a new tab creates the new tab at the most left Dec 23, 2016
@bbondy
Copy link
Member

bbondy commented Dec 23, 2016

This is only a problem if you're using Electron 2.0.5 or lower.
I'd recommend if testing from master to do a build from brave/browser-laptop-bootstrap.
it's a long 1 time setup but you'll be up to date with electron and browser-laptop changes, which we are frequently making especially right now.

To setup just npm install, npm run init, and npm run build.
The init can take an hour and the build might take a couple, but incremental builds after that are fast.

@bbondy bbondy closed this as completed Dec 23, 2016
@bbondy
Copy link
Member

bbondy commented Dec 23, 2016

Please re-open if you find it's an issue on 2.0.6 or later though.

@luixxiul
Copy link
Contributor Author

Test plan:

Open any link by clicking it pushing the command key

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants