Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change lang setting on about:preferences should always show the restart notification bar #6750

Closed
srirambv opened this issue Jan 19, 2017 · 4 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 19, 2017

Test plan

See #13073

Original issue description

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Change in language doesn't always show the restart notification bar

Expected behavior:
Should always show the restart notification bar when a different language is selected each time

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev c60b783

  • Steps to reproduce:

    1. Do a clean install of 0.13.0 preview 10
    2. Change the browser language from English to any other language, notice the restart notification bar is shown
    3. Without closing select a different language, notice the restart notification bar is gone
    4. Without restarting change the language again, restart notification bar is shown
  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    lang

  • Any related issues:

@srirambv
Copy link
Collaborator Author

Also Requires restart text is missing next to language similar to other options in settings which initiates a restart

@bbondy bbondy removed this from the 0.13.1 milestone Jan 22, 2017
@luixxiul luixxiul changed the title Change in language doesn't always show the restart notification bar Change lang setting on about:preferences should always show the restart notification bar Feb 2, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@sergio-rojasa
Copy link

I would like to work on this issue

@srirambv
Copy link
Collaborator Author

@sergiorojasa Please submit a PR. I have self assigned the issue so that no one else takes it.

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 14, 2018

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.13.4 using the following build:

  • 0.23.11 6565c06
  • Muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.