Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Helpful Hints: "Bravery Panel" reference used in Settings #6806

Closed
lukemulks opened this issue Jan 22, 2017 · 2 comments
Closed

Helpful Hints: "Bravery Panel" reference used in Settings #6806

lukemulks opened this issue Jan 22, 2017 · 2 comments

Comments

@lukemulks
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Noticed that within the Helpful Hints in the Settings section that "Bravery Panel" is referenced, instead of "Shields"

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10

  • Brave Version (revision SHA):
    0.12.15

  • Steps to reproduce:

    1. Open the Settings section
    2. Rotate through the Helpful Hints until you see the one re: HTTPSe
    3. Note the Bravery Panel reference
  • Actual result:
    Bravery Panel

  • Expected result:
    Shields Settings || Shields Site Settings || Shields Panel

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

bravery-panel-01212017

siteshieldsettings-01212017

  • Any related issues:
    na
@lukemulks lukemulks added bug design A design change, especially one which needs input from the design team. OS/Windows settings labels Jan 22, 2017
@luixxiul luixxiul added copy/content/text bug/good-first-bug and removed design A design change, especially one which needs input from the design team. OS/Windows bug labels Jan 22, 2017
@luixxiul luixxiul added this to the 0.13.1 milestone Jan 22, 2017
@cndouglas
Copy link

Text to change: https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/locales/en-US/preferences.properties#L117

@cndouglas
Copy link

Fixed with 94f8976.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.