Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Stop seeding" button on torrent viewer #6815

Closed
luixxiul opened this issue Jan 23, 2017 · 4 comments
Closed

"Stop seeding" button on torrent viewer #6815

luixxiul opened this issue Jan 23, 2017 · 4 comments
Labels

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:
"Stop seeding" button on torrent viewer should be implemented

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.13.0 RC5

  • Steps to reproduce:

    1. Open https://codepen.io/ferossity/full/qaezaB/
    2. Click "sintel.mp4"
    3. Click "Start download"
    4. Wait until the download is finished
    5. The button "seeding" which cannot be clicked appears
    6. Close the tab
    7. Reopen the tab
    8. The button still remains
  • Actual result:
    clipboard01

  • Expected result:
    There should be a stop seeding button

  • Any related issues: Feature: WebTorrent Integration #3256

CC @feross @dcposch: Is stopping not intended?

@dcposch
Copy link
Contributor

dcposch commented Jan 23, 2017

When you close all tabs for a given torrent, after a timeout of a few seconds, that torrent will be removed. In other words, it'll stop downloading or seeding.

@feross any reason why the button is disabled? What if the button was just a toggle, so that people could stop an in-progress download or stop seeding without closing the tab?

@srirambv
Copy link
Collaborator

same as #6768

@feross
Copy link
Contributor

feross commented Jan 23, 2017

The button starts out as "Start Download". After it's clicked, we disable it and change the label to "Seeding".

That's totally arbitrary though. It would be fine as a toggle. Does the button pause the download, or remove it entirely from the filesystem?

Also, we need to make sure that when another tab is opened (which will re-add the torrent), that the previously paused tab gets it's state updated correctly.

@feross
Copy link
Contributor

feross commented Mar 2, 2017

Closing as duplicate of #6768

@feross feross closed this as completed Mar 2, 2017
@bsclifton bsclifton added the duplicate Issue has already been reported label Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants