Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark hanger shows a wrong folder name #7032

Closed
srirambv opened this issue Feb 3, 2017 · 2 comments
Closed

Bookmark hanger shows a wrong folder name #7032

srirambv opened this issue Feb 3, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 3, 2017 •
edited by luixxiul
Loading

Test plan

specified below

Describe the issue you encountered: Bookmark hanger shows a wrong folder name

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 x64

  • Brave Version (revision SHA): 0.13.2 ce14f5d

  • Steps to reproduce:
    1. Add a bookmark
    2. move it to a different folder
    3. Click on the bookmark icon
      • Make sure folder is selected as bookmark toolbar, instead of the new folder in which you put it
    4. Import boomarks from file/browser which has folders in it
    5. Open the bookmarked page
    6. Click on the bookmark icon
      • Bookmark toolbar remains location rather than the folder name

  • Actual result: Root folder name is displayed, even if the bookmark exists under nested folder

  • Expected result: Correct folder name where the bookmark exist should be displayed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No. Shows correct folder name in 0.13.1

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues: Bookmarks shows wrong folder name #4983
@srirambv srirambv added this to the 0.13.3 milestone Feb 3, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul mentioned this issue May 29, 2017
Closed
@luixxiul luixxiul changed the title Bookmark shows wrong folder name Bookmark hanger shows a wrong folder name May 29, 2017
@luixxiul luixxiul mentioned this issue May 29, 2017
Closed
7 tasks
@NejcZdovc
Copy link
Contributor

@srirambv can you please test if this is still an issue?

@luixxiul
Copy link
Contributor

luixxiul commented Sep 6, 2017

it is:

bug

Brave: 0.18.27
rev: eba55a1
Muon: 4.3.16
libchromiumcontent: 60.0.3112.113
V8: 6.0.286.56
Node.js: 7.9.0
Update Channel: dev
OS Platform: Linux
OS Release: 4.9.0-3-amd64
OS Architecture: x64

@NejcZdovc NejcZdovc self-assigned this Sep 6, 2017
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Fixes bookmark move location cache
6febc32 
Resolves brave#7032

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 6, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Fixes bookmark move location cache
dc49efa 
Resolves brave#7032

Auditors:

Test Plan:
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
Merge pull request #10819 from NejcZdovc/hotfix/#7032-hanger
b47daf7 
Fixes bookmark move location cache
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags