Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Selecting subfolders on the bookmark bar which have many entries can be quite laggy #7053

Closed
luixxiul opened this issue Feb 4, 2017 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

Test plan

#10301 (comment)


Describe the issue you encountered: While doing QA for #4879 I noticed that selecting subfolders on the bookmark bar which have many bookmarks can be laggy. It sometimes takes 1 second to open subfolders.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.13.2 RC3

  • Steps to reproduce:

    1. Import a number of bookmarks
    2. Open a folder on bookmark bar which has many entries
    3. Open subfolders by moving the mouse fast
  • Actual result: The context menu is selected quite slowly

  • Expected result: the subfolders should be selected instantly

  • Screenshot if needed:
    lag

  • Any related issues:

@luixxiul luixxiul added the perf label Feb 4, 2017
@srirambv
Copy link
Collaborator

srirambv commented Feb 4, 2017

This happens only when a large amount of bookmarks are loaded. With just few bookmarks there is no perf issue
shieldsmenu

@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 4, 2017

@ayumi Is this issue fixed with one of the PRs you recently pushed?

@luixxiul luixxiul added the bug label Jun 4, 2017
@sjlehn
Copy link
Contributor

sjlehn commented Aug 7, 2017

Possibly related - on Mac OSX (El Capitan), when selecting a group of bookmarks and moving them to another folder there is considerable lag

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 7, 2017

@NejcZdovc do you think this was fixed with the recent split PR?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Aug 7, 2017
@NejcZdovc
Copy link
Contributor

@luixxiul I think it will be fixed with this PR #10301

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 7, 2017

I updated the 1st post on #10301 (comment)

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Aug 7, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 7, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 7, 2017
@luixxiul
Copy link
Contributor Author

Closing for now to check if #10301 (comment) really fixes the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.