Object expected in chrome.storage.sync.get callback

[jonathansampson]

When calling chrome.storage.sync.get, the user passes along a callback function. When this function is executed, the first argument is expected to be an object. Presently, it is undefined. This causes errors to be thrown when attempting to access any property.

As an example, the following is from the Mercury extension:

chrome.storage.sync.get(null, function (items) {
    myObj = items;
    _this2.setState({
        theme: myObj.mercuryTheme || 'light',
        textSize: myObj.mercuryTextSize || 'medium',
        typography: myObj.mercuryTypography || 'serif',
        settingsLoaded: true,
        showApproveTos: myObj.mercuryApproveTos !== undefined ? myObj.mercuryApproveTos : true
    });
    chrome.runtime.sendMessage({ type: 'settingsLoaded' });
});

During the attempt to setState, the call to myObj.mercuryTheme will throw.

[bsclifton]

Moving to 0.13.7

[bridiver]

didn't we talk about making sync storage just point to regular storage?

[jonathansampson]

@bridiver We had indeed floated that idea in the past :) Of course, now that we have Brave Sync, I wonder how feasible it would be to integrate there.

[bridiver]

doing it right now

[bridiver]

it will actually point to a separate local storage instance

[bridiver]

fixed brave/muon@6c89ced

[bsclifton]

marked as no QA needed; extension compatibility tracked with https://github.com/brave/browser-laptop/projects/1