When re-launching when maximised, window is offset by several pixels & no longer maximised

[ghost]

Test plan

Windows

1. Launch Brave and maximize the window.
2. Quit and relaunch Brave again
3. Window should retain it's maximized status
4. Enter fullscreen mode (F11)
5. Quit and relaunch Brave again
6. Window should retain it's fullscreen status

macOS

1. Launch Brave and try to maximize the window by double clicking in empty space in the titlebar area (note: this doesn't always seem to work- if not, try to make window take up entire area)
2. Quit and relaunch Brave again
3. Window should retain it's size
4. Enter the macOS fullscreen app mode by pressing the Green traffic light button
5. Quit and relaunch Brave again
6. Window should retain it's fullscreen status

Original issue description

• Description:
  When re-launching the browser (after the previous session ended with the browser maximised), instead of launching maximised again, the window is offset by several pixels vertically & horizontally, and is no longer maximised.

• Platform:
  Windows 10 64-bit

• Brave Version:
  Brave: 0.13.5
  rev: 1db81cb
  Muon: 2.56.8
  libchromiumcontent: 56.0.2924.87
  V8: 5.6.326.50
  Node.js: 7.4.0
  Update Channel: dev
  os.platform: win32
  os.release: 10.0.14393
  os.arch: x64

• Steps to reproduce:

  1. Set the window to maximised.
  2. Close the browser entirely.
  3. Open the browser.

• Actual result:
  The window is offset by several pixels vertically & horizontally, and the OS no longer considers it maximised: https://i.imgur.com/rJ7VBtV.png

• Expected result:
  The Window should replicate that of what it was when previously closed - i.e. maximised: https://i.imgur.com/dG3Atrp.png

[bsclifton]

Possibly related: #3754, #5267, and #6602

[bsclifton]

found it- caused by this commit: 6d72210

[ghost]

The plan to solve this (Start, maximize, exit, start) doesn't solve it for me. I hope you fix this in future versions, because this is the only big flaw when I am using it :)

[NejcZdovc]

@ChiSeeker hi, I already have a PR up (#10458) for this and it should fix all this problems. Thank you for your report 👍

[ghost]

​Hello, thank you, but I don't understand it. Could this be integrated into Brave exe file or when updated? Are you from Slovenia? Thanks​ Damjan

…

On 18 August 2017 at 23:28, Nejc Zdovc ***@***.***> wrote: @ChiSeeker <https://github.com/chiseeker> hi, I already have a PR up ( #10458 <#10458>) for this and it should fix all this problems. Thank you for your report 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7664 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASSgVENugMjxiPyEtTtTex0Ea3iyE4HQks5sZgHvgaJpZM4Maiyd> .

[NejcZdovc]

@ChiSeeker yes this will be merged into the master branch and released with the version 0.20. So you will get it as an update automatically. And yeah I am from Slovenia 😃