Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed vertical center display of URL bar (Remove "top: 1px" from .urlbarForm>*) #7805

Closed
luixxiul opened this issue Mar 21, 2017 · 0 comments · Fixed by #7807
Closed

Fixed vertical center display of URL bar (Remove "top: 1px" from .urlbarForm>*) #7805

luixxiul opened this issue Mar 21, 2017 · 0 comments · Fixed by #7807
Assignees
@luixxiul
Labels
feature/URLbar polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Because the top panel was updated to the flat design with #7546 and #7739, I think we do not need to place the elements under .urlbarForm 1px down.

From:
screenshot 2017-03-21 22 51 56

To:
screenshot 2017-03-21 22 52 28

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 64b381a

  • Any related issues:
@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. suggestion labels Mar 21, 2017
@luixxiul luixxiul self-assigned this Mar 21, 2017
@luixxiul luixxiul mentioned this issue Mar 21, 2017
Merged
4 tasks
@luixxiul luixxiul added this to the 0.14.0 milestone Mar 22, 2017
@alexwykoff alexwykoff mentioned this issue Mar 24, 2017
Closed
@alexwykoff alexwykoff changed the title Remove "top: 1px" from .urlbarForm>* Fixed vertical center display of urlbar Mar 24, 2017
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul changed the title Fixed vertical center display of urlbar Fixed vertical center display of URL bar (Remove "top: 1px" from .urlbarForm>*) Mar 29, 2017
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/URLbar polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Remove top:1px from .urlbarForm > *
3 participants
@alexwykoff @luixxiul @srirambv