Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updated style for Brave Payment statement - refactor contributionStatement.js with Aphrodite #7883

Closed
luixxiul opened this issue Mar 25, 2017 · 0 comments
Closed

Updated style for Brave Payment statement - refactor contributionStatement.js with Aphrodite #7883

luixxiul opened this issue Mar 25, 2017 · 0 comments
Assignees
@luixxiul
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 25, 2017 •
edited
Loading

Test plan

#7887 (comment)

Describe the issue you encountered:
Refactor contributionStatement.js with Aphrodite

Initial work: https://github.com/luixxiul/browser-laptop/commit/4ca21420b62af33694777b1e3484bdafda630194

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

screenshot 2017-03-25 18 04 06

  • Any related issues:
@luixxiul luixxiul added this to the 0.14.1 milestone Mar 25, 2017
@luixxiul luixxiul self-assigned this Mar 25, 2017
@luixxiul luixxiul mentioned this issue Mar 25, 2017
Merged
4 tasks
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@luixxiul luixxiul mentioned this issue Apr 5, 2017
Closed
cezaraugusto pushed a commit that referenced this issue Apr 5, 2017
@luixxiul @cezaraugusto
Refactor contributionStatement.js with Aphrodite (#7887)
7c32ef1 
Closes #7883

- Remove contributionStatement.less
- Replace inlined braveLogo with a PNG file, verifiedIcon with a SVG file
- Introduce constants for margins, borders, paddings, light gray, etc

Auditors:

Test Plan:
1. npm run add-simulated-payment-history
2. Open about:preferences#payments
3. Display the payments history
@luixxiul luixxiul changed the title Refactor contributionStatement.js with Aphrodite Modified contributionStatement.js with Aphrodite Apr 5, 2017
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Apr 24, 2017
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Modified contributionStatement.js with Aphrodite Updated style for Brave Payment statement Apr 25, 2017
@luixxiul luixxiul changed the title Updated style for Brave Payment statement Updated style for Brave Payment statement - refactor contributionStatement.js with Aphrodite Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @cezaraugusto @srirambv