Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed localization ability for delete confirmation message #7958

Closed
luixxiul opened this issue Mar 29, 2017 · 2 comments
Closed

Fixed localization ability for delete confirmation message #7958

luixxiul opened this issue Mar 29, 2017 · 2 comments
Assignees
@cndouglas
Labels
feature/download l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Delete confirmation message ("Delete?") should be able to be localizable.

c5026e5#diff-f544daf754a6ad72801af50dbb179b6eR94

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): 0.14.0 RC1

  • Steps to reproduce:

    1. Download a file
    2. Click the bin icon on the download item

  • Extra QA steps:

    1. Localize the string on Transifex
    2. Update localization files
    3. Change the language setting
    4. Download a file
    5. Click the bin icon
    6. Make sure the message is successfully displayed in the same language

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.14.1 milestone Mar 29, 2017
@cndouglas cndouglas self-assigned this Mar 30, 2017
@cndouglas cndouglas mentioned this issue Mar 30, 2017
Merged
4 tasks
@cndouglas
Copy link

PR: #7988

@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
bridiver pushed a commit that referenced this issue Apr 4, 2017
@bridiver
Localize download delete confirmation
39af2de 
Fixes #7958
@luixxiul
Copy link
Contributor Author

Tested on Japanese.

This was referenced Apr 17, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Delete confirmation message ("Delete?") should be able to be localizable Fixed localization ability for delete confirmation message Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cndouglas cndouglas

Labels
feature/download l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv @cndouglas