Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark moved to a folder on the toolbar cannot be removed via the star button #8022

Closed
luixxiul opened this issue Apr 1, 2017 · 3 comments
Closed

Bookmark moved to a folder on the toolbar cannot be removed via the star button #8022

luixxiul opened this issue Apr 1, 2017 · 3 comments
Assignees
@NejcZdovc
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 1, 2017 •
edited
Loading

Test plan

#10136 (comment)

Describe the issue you encountered: Bookmark in a folder on the toolbar cannot be removed via the star button, unless you select the bookmark folder into which you moved the bookmark. By default it is set to "bookmark toolbar" and not overwritten.

I am not sure if this is a regression.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version (revision SHA): 0.14.1 RC1

  • Steps to reproduce:

    1. Open a page
    2. Bookmark it
    3. Add a bookmark folder
    4. Move the bookmark into the folder
    5. Click the star button on the URL bar
    6. Click "Remove" -> bookmark is not removed
    7. Click the star
    8. Choose the folder and click "Remove" -> bookmark is removed

  • Actual result: the bookmark folder is not overwritten after moving the bookmark to another folder from "bookmark toolbar"

  • Expected result: it should be overwritten

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.14.2 milestone Apr 1, 2017
@bsclifton
Copy link
Member

Moving to 0.14.3- without an owner, this is at risk

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 4, 2017
@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@bsclifton
Copy link
Member

site entries have folder as the key- we'll need to consider this when removing

@luixxiul luixxiul changed the title Bookmark in a folder on the toolbar cannot be removed via the star button Bookmark moved to a folder on the toolbar cannot be removed via the star button May 29, 2017
This was referenced May 29, 2017
Closed
Closed
@alexwykoff alexwykoff removed this from the 0.18.x (Developer Channel) milestone Jun 13, 2017
@bsclifton bsclifton removed the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Jun 13, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 21, 2017
@cezaraugusto cezaraugusto added this to the 0.19.x (Nightly Channel) milestone Jun 21, 2017
@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel), 0.20.x (Developer Channel) Jul 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 25, 2017
@NejcZdovc
Splits sites object in the app state
94a95b0 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 26, 2017
@NejcZdovc
Splits sites object in the app state
da5b46b 
Resolves brave#1856
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5699
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jul 26, 2017
Merged
8 tasks
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
ed72c5d 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
ea28b4d 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 27, 2017
@NejcZdovc
Splits sites object in the app state
d808cb9 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
c754a56 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
23ee608 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 28, 2017
@NejcZdovc
Splits sites object in the app state
5efcb2c 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 31, 2017
@NejcZdovc
Splits sites object in the app state
744a3ad 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 31, 2017
@NejcZdovc
Splits sites object in the app state
daa7474 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Aug 1, 2017
@NejcZdovc
Splits sites object in the app state
9d83149 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Aug 3, 2017
@NejcZdovc
Splits sites object in the app state
f618f0e 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
8 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @LaurenWags